From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86C80250BED; Wed, 21 May 2025 10:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747822344; cv=none; b=Kjd/6/ncJD9W6+FQSVdt4jnsxZxxyU30mZp863u/SlIQ3o0TFYzp9U9pBJ3Qplb7B5bmsXg2naR4i3eD1W9bEZNabBbqLuqBEwFgysp/c1F5LFZ4CtTOKOwZ+snUy/8FDjfy6BgQTV71gunRTpxEf/OdjUH4cc/9xf/vcAREX+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747822344; c=relaxed/simple; bh=21cNdzYwUJJBEkAHlt7+sFsml8d7DmKbNlD2kUZGKoQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uys+MivWxrDAhKCtWUm7m5uPR0nGz5eTY/C7hFJ98swMXV9jS2JREOrlyDQ1nkly9ztqPsmSgP/aev6P9cph8iWJiWhRu/tU6pF0I1I3pjWukgR0XgHro0BnSWtupWccRpTOmb9r5RkOtlQINEAggjZw6YwMC20cNSzQMdEUXjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YLXOzE9H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YLXOzE9H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA7E2C4CEED; Wed, 21 May 2025 10:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747822344; bh=21cNdzYwUJJBEkAHlt7+sFsml8d7DmKbNlD2kUZGKoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YLXOzE9HyCy+kC79+nUGLtvp+0cxfR2TUqkZ6h0MDnnvdFk9pskQlEjRl/46ec7W2 TH/x2jlNbam+Us8NSZrtDSx/HbFXHChCs8KdGoSNvyu+6GIK/tABEAfZ5EIJ9jmwiU W1JLhNCmMAminpUveLFmvUvUzyFGZbmBJ7QRISsH67ON2Eldjw5CzZuxmWFFKjhaMG 5hnpVMxcr0ovTQjUkq13+jJoGGK4Rsio37/Sc3vS01CWAzkYtLStJsFev+cYzyIB6D cA1Q961SLiRbMcoD6c9XC2jiHOXhz5nQrAyKFReCRaKuiywBNVKDMxR59cSAmmioWM B1TrXzju+oOcQ== Date: Wed, 21 May 2025 13:12:20 +0300 From: Jarkko Sakkinen To: Stefano Garzarella Cc: linuxppc-dev@lists.ozlabs.org, Peter Huewe , Jens Wiklander , linux-integrity@vger.kernel.org, Alexandre Belloni , linux-arm-kernel@lists.infradead.org, Nicolas Ferre , Nicholas Piggin , Sumit Garg , James Bottomley , Claudiu Beznea , Madhavan Srinivasan , Jason Gunthorpe , linux-kernel@vger.kernel.org, Christophe Leroy , Naveen N Rao , Michael Ellerman Subject: Re: [PATCH v5 4/4] tpm/tpm_svsm: support TPM_CHIP_FLAG_SYNC Message-ID: References: <20250514134630.137621-1-sgarzare@redhat.com> <20250514134630.137621-5-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 21, 2025 at 09:13:34AM +0200, Stefano Garzarella wrote: > On Tue, 20 May 2025 at 22:02, Jarkko Sakkinen wrote: > > On Tue, May 20, 2025 at 06:06:50PM +0200, Stefano Garzarella wrote: > > > On Thu, 15 May 2025 at 03:45, Jarkko Sakkinen wrote: > > > > On Wed, May 14, 2025 at 03:46:30PM +0200, Stefano Garzarella wrote: > > > > > From: Stefano Garzarella > > > > > > > > > > This driver does not support interrupts, and receiving the response is > > > > > synchronous with sending the command. > > > > > > > > > > Enable synchronous send() with TPM_CHIP_FLAG_SYNC, which implies that > > > > > ->send() already fills the provided buffer with a response, and ->recv() > > > > > is not implemented. > > > > > > > > > > Keep using the same pre-allocated buffer to avoid having to allocate > > > > > it for each command. We need the buffer to have the header required by > > > > > the SVSM protocol and the command contiguous in memory. > > > > > > > > > > Signed-off-by: Stefano Garzarella > > > > > --- > > > > > v5: > > > > > - changed order and parameter names to match tpm_try_transmit() [Jarkko] > > > > > v4: > > > > > - reworked commit description [Jarkko] > > > > > --- > > > > > drivers/char/tpm/tpm_svsm.c | 27 +++++++++++---------------- > > > > > 1 file changed, 11 insertions(+), 16 deletions(-) > > > > > > > [...] > > > > > > > > > I can pick this for 6.16. > > > > > > Great, thanks! > > > > Can you rebase this on top of my next branch and send one more version > > of the series (fake ancestor crap)? > > I tried, but the last patch (this one) is based on the series merged > on the tip tree, where I introduced tpm_svsm. > I can see that series in linux-next merged with commit > 16a56ee59ab8ee05e67de35bbb5782ef9cfb4f07, > but I can't see it in your next tree [1]. > > How do we proceed in such cases? > > Just to be sure, did I use the right tree? Thanks for the remark. Lemme check tonight. Hold on doing anything ;-) We'll get there... > > Thanks, > Stefano > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/?h=next > > BR, Jarkko