public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ian Rogers <irogers@google.com>,
	James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>
Subject: Re: IBS perf test failures on 9950x3d
Date: Wed, 21 May 2025 13:50:04 -0700	[thread overview]
Message-ID: <aC48fFyR1NN4RPz8@google.com> (raw)
In-Reply-To: <aCzqdn3AJji_yPpQ@x1>

On Tue, May 20, 2025 at 05:47:50PM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, May 20, 2025 at 04:31:29PM +0530, Ravi Bangoria wrote:
> > > Telling that to the user and possibly skipping the test if viable using
> > > uname to get the version and if less than v6.15-rc1 print "Skip (needs
> > > v6.15-rc1 or newer)" may be an option.
>  
> > > Then if the bug somehow reappears, people running 'perf test' will flag
> > > it.
>  
> > Sure. Attaching a patch at the end.
> 
> Thanks, I'm applying it.
> 
> But now that I think about it, it may well be the case that, say, RHEL
> backports the fixes in v6.15 for an enterprise kernel that has an
> "older" version, so probably the best is for execute the test, if it
> fails, then do the version check to decide if it is an unexpected
> failure.

Yeah, that was my concern too.  I'm fine with having it in perf test and
skip older kernels though.

> 
> But this can be done on top, lets make progress and apply your patch.
> 
> > > And I think having it in 'perf test' as well may make the feature to be
> > > tested more widely, both by those who run selftests as well as by people
> > > trying just 'perf test'.
> > 
> > Yeah, that was precisely the reason I did it in 'perf test'.

+1.

Thanks,
Namhyung


      reply	other threads:[~2025-05-21 20:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-17  2:02 IBS perf test failures on 9950x3d Arnaldo Carvalho de Melo
2025-05-17 12:03 ` Ravi Bangoria
2025-05-18 18:22   ` Namhyung Kim
2025-05-19 16:39     ` Ravi Bangoria
2025-05-19 18:28     ` Arnaldo Carvalho de Melo
2025-05-20 11:01       ` Ravi Bangoria
2025-05-20 20:47         ` Arnaldo Carvalho de Melo
2025-05-21 20:50           ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aC48fFyR1NN4RPz8@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=ravi.bangoria@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox