From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Frank Wunderlich <frank-w@public-files.de>,
linux@fw-web.de, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
arinc.unal@arinc9.com, Landen.Chao@mediatek.com,
dqfext@gmail.com, sean.wang@mediatek.com, lorenzo@kernel.org,
nbd@nbd.name, netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: Re: [PATCH v1 09/14] arm64: dts: mediatek: mt7988: add switch node
Date: Sun, 11 May 2025 22:55:50 +0100 [thread overview]
Message-ID: <aCEc5tYPivxvRVDK@makrotopia.org> (raw)
In-Reply-To: <74afe286-2adb-42d3-9491-881379053e36@lunn.ch>
On Sun, May 11, 2025 at 11:25:27PM +0200, Andrew Lunn wrote:
> > i will move that into the board dtsi file in v2 because "normal" bpi-r4 and 2g5 variant are same here.
>
> Maybe you just need to expand the commit message? What does this .dtsi
> actually represent? The SoC, or what is common across a number of
> boards?
mt7988a.dtsi represents the SoC, and thus there shouldn't be any
labels assigned to the DSA ports.
In case of the BananaPi R4 there are two different boards, one with 2x
SFP+ and one with 1x SFP+ + 1x 2500Base-T (with PoE-in), hence there is
a dtsi files for all the parts shared among the two boards. I suppose
Frank meant to move the labels to that board dtsi file, and that's
correct imho as the labels of the 1G switch ports are the same on BPi-R4
and BPi-R4-PoE.
next prev parent reply other threads:[~2025-05-11 22:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 14:19 [PATCH v1 00/14] further mt7988 devicetree work Frank Wunderlich
2025-05-11 14:19 ` [PATCH v1 01/14] dt-bindings: net: mediatek,net: update for mt7988 Frank Wunderlich
2025-05-12 16:21 ` Conor Dooley
2025-05-12 17:33 ` Frank Wunderlich
2025-05-12 21:01 ` Conor Dooley
2025-05-11 14:19 ` [PATCH v1 02/14] dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition " Frank Wunderlich
2025-05-11 16:34 ` Andrew Lunn
2025-05-11 16:45 ` Andrew Lunn
2025-05-11 17:11 ` Aw: " Frank Wunderlich
2025-05-14 21:16 ` Rob Herring (Arm)
2025-05-11 14:19 ` [PATCH v1 03/14] dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus Frank Wunderlich
2025-05-14 21:18 ` Rob Herring
2025-05-15 5:40 ` Aw: " Frank Wunderlich
2025-05-11 14:19 ` [PATCH v1 04/14] arm64: dts: mediatek: mt7988: add spi controllers Frank Wunderlich
2025-05-11 14:19 ` [PATCH v1 05/14] arm64: dts: mediatek: mt7988: move uart0 and spi1 pins to soc dtsi Frank Wunderlich
2025-05-11 14:19 ` [PATCH v1 06/14] arm64: dts: mediatek: mt7988: add cci node Frank Wunderlich
2025-05-11 14:19 ` [PATCH v1 07/14] arm64: dts: mediatek: mt7988: add phy calibration efuse subnodes Frank Wunderlich
2025-05-11 14:19 ` [PATCH v1 08/14] arm64: dts: mediatek: mt7988: add basic ethernet-nodes Frank Wunderlich
2025-05-11 16:38 ` Andrew Lunn
2025-05-12 16:54 ` Frank Wunderlich (linux)
2025-05-11 14:19 ` [PATCH v1 09/14] arm64: dts: mediatek: mt7988: add switch node Frank Wunderlich
2025-05-11 16:42 ` Andrew Lunn
2025-05-11 17:29 ` Aw: " Frank Wunderlich
2025-05-11 21:25 ` Andrew Lunn
2025-05-11 21:55 ` Daniel Golle [this message]
2025-05-11 16:06 ` Aw: [PATCH v1 00/14] further mt7988 devicetree work Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCEc5tYPivxvRVDK@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox