Re: [PATCH v3 13/23] irqchip: Add driver for the RPMI system MSI service group

Andy Shevchenko
2025-05-21T14:11:14Z

On Wed, May 21, 2025 at 05:07:05PM +0530, Anup Patel wrote:
> On Mon, May 12, 2025 at 12:20 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sun, May 11, 2025 at 07:09:29PM +0530, Anup Patel wrote:

...

> > > +#include <linux/bitfield.h>
> > > +#include <linux/bitops.h>
> > > +#include <linux/cpu.h>
> > > +#include <linux/interrupt.h>
> > > +#include <linux/irqchip.h>
> > > +#include <linux/mailbox_client.h>
> > > +#include <linux/mailbox/riscv-rpmi-message.h>
> > > +#include <linux/module.h>
> > > +#include <linux/msi.h>
> > > +#include <linux/of_irq.h>
> > > +#include <linux/platform_device.h>
> > > +#include <linux/printk.h>
> > > +#include <linux/smp.h>
> >
> > + types.h
> >
> > Actually this one is most clean, the rest of the patches where the new code
> > is introduced has semi-random list of the inclusions, please, follow the IWYU
> > principle.
>
> Sure, I will simplify the #includes

Oh, IWYU (Include What You Use) is not about simplification. It's about
comprehension. It usually means that *more* headers need to be included
and *only some* of the existing will be dropped.

--
With Best Regards,
Andy Shevchenko