From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: perex@perex.cz, tiwai@suse.com, krzysztof.h1@wp.pl,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: msnd: Remove midi code
Date: Mon, 12 May 2025 11:18:43 +0000 [thread overview]
Message-ID: <aCHZE7G2kTeGrDlN@gallifrey> (raw)
In-Reply-To: <87ldr2uush.wl-tiwai@suse.de>
* Takashi Iwai (tiwai@suse.de) wrote:
> On Sun, 11 May 2025 19:29:57 +0200,
> linux@treblig.org wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > Nothing calls snd_msndmidi_new()
> > thus nothing sets chip->msndmidi_mpu
> > The call to snd_msndmidi_input_read is gated on that being set,
> > so snd_msndmidi_input_read() won't be called either.
> >
> > This is probably a missing call to snd_msndmidi_new(), but since
> > this is ancient code, it's probably best to remove it (especially
> > since I don't have the hardware to test it).
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Applied now. Thanks.
Thanks!
Dave
>
> Takashi
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2025-05-12 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 17:29 [PATCH] ALSA: msnd: Remove midi code linux
2025-05-12 7:56 ` Takashi Iwai
2025-05-12 11:18 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCHZE7G2kTeGrDlN@gallifrey \
--to=linux@treblig.org \
--cc=krzysztof.h1@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox