From: Petr Mladek <pmladek@suse.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Peter Zijlstra <peterz@infradead.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
Josh Poimboeuf <jpoimboe@redhat.com>,
mingo@kernel.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, jpoimboe@kernel.org, jikos@kernel.org,
joe.lawrence@redhat.com, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] sched,livepatch: Untangle cond_resched() and live-patching
Date: Wed, 14 May 2025 11:51:44 +0200 [thread overview]
Message-ID: <aCRnsN-2x4vpjpCx@pathway.suse.cz> (raw)
In-Reply-To: <alpine.LSU.2.21.2505131604530.19621@pobox.suse.cz>
On Tue 2025-05-13 16:05:51, Miroslav Benes wrote:
> On Tue, 13 May 2025, Peter Zijlstra wrote:
>
> > On Tue, May 13, 2025 at 03:34:50PM +0200, Miroslav Benes wrote:
> > > Hi,
> > >
> > > thanks for the updated version.
> > >
> > > On Fri, 9 May 2025, Sebastian Andrzej Siewior wrote:
> > >
> > > > From: Peter Zijlstra <peterz@infradead.org>
> > > >
> > > > With the goal of deprecating / removing VOLUNTARY preempt, live-patch
> > > > needs to stop relying on cond_resched() to make forward progress.
> > > >
> > > > Instead, rely on schedule() with TASK_FREEZABLE set. Just like
> > > > live-patching, the freezer needs to be able to stop tasks in a safe /
> > > > known state.
> > > >
> > > > Compile tested only.
> > >
> > > livepatch selftests pass and I also ran some more.
> > >
> > > > [bigeasy: use likely() in __klp_sched_try_switch() and update comments]
> > > >
> > > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > >
> > > Acked-by: Miroslav Benes <mbenes@suse.cz>
> > >
> > > A nit below if there is an another version, otherwise Petr might fix it
> > > when merging.
> >
> > Petr or Peter?
> >
> > That is, who are we expecting to merge this :-)
>
> Petr Mladek if it goes through the live patching tree, you if tip. Feel
> free to pick it up :).
IMHO, it might be easier when it goes via tip. Peter, feel free to
take it.
The patch does not create any conflict with the klp tree.
But I guess that there might be some dependent patches in tip...
That said, I could take it via the livepatch tree if Peter preferred
it from some reasons.
Anyway, the patch looks good and passes the tests. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Tested-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2025-05-14 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 11:36 [PATCH v2] sched,livepatch: Untangle cond_resched() and live-patching Sebastian Andrzej Siewior
2025-05-13 13:34 ` Miroslav Benes
2025-05-13 14:03 ` Peter Zijlstra
2025-05-13 14:05 ` Miroslav Benes
2025-05-14 9:51 ` Petr Mladek [this message]
2025-05-14 11:17 ` Peter Zijlstra
2025-05-14 9:44 ` Petr Mladek
2025-05-13 21:40 ` Josh Poimboeuf
2025-05-14 9:59 ` Thomas Gleixner
2025-05-14 11:17 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2025-05-14 11:26 ` tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCRnsN-2x4vpjpCx@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mgorman@suse.de \
--cc=mingo@kernel.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox