From: Mark Brown <broonie@kernel.org>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org, andriy.shevchenko@intel.com,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v8 05/11] regmap: irq: Add support for chips without separate IRQ status
Date: Wed, 14 May 2025 11:59:35 +0200 [thread overview]
Message-ID: <aCRph9Qo7BbtTjIR@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20250509-mdb-max7360-support-v8-5-bbe486f6bcb7@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]
On Fri, May 09, 2025 at 11:14:39AM +0200, Mathieu Dubois-Briand wrote:
> Some GPIO chips allow to rise an IRQ on GPIO level changes but do not
> provide an IRQ status for each separate line: only the current gpio
> level can be retrieved.
This doesn't build in a wide range of configurations (none at all
AFAICT):
/build/stage/linux/drivers/base/regmap/regmap-irq.c: In function ‘regmap_add_irq
_chip_fwnode’:
/build/stage/linux/drivers/base/regmap/regmap-irq.c:914:88: error: macro "array_
size" requires 2 arguments, but only 1 given
914 | memcpy(d->prev_status_buf, d->status_buf, array_size(d->
prev_status_buf));
|
^
In file included from /build/stage/linux/include/linux/string.h:13,
from /build/stage/linux/include/linux/bitmap.h:13,
from /build/stage/linux/include/linux/cpumask.h:12,
from /build/stage/linux/include/linux/smp.h:13,
from /build/stage/linux/include/linux/lockdep.h:14,
from /build/stage/linux/include/linux/spinlock.h:63,
from /build/stage/linux/include/linux/sched.h:2213,
from /build/stage/linux/include/linux/ratelimit.h:6,
from /build/stage/linux/include/linux/dev_printk.h:16,
from /build/stage/linux/include/linux/device.h:15,
from /build/stage/linux/drivers/base/regmap/regmap-irq.c:10:
/build/stage/linux/include/linux/overflow.h:327:9: note: macro "array_size" defined here
327 | #define array_size(a, b) size_mul(a, b)
| ^~~~~~~~~~
/build/stage/linux/drivers/base/regmap/regmap-irq.c:914:59: error: ‘array_size’ undeclared (first use in this function)
914 | memcpy(d->prev_status_buf, d->status_buf, array_size(d->prev_status_buf));
| ^~~~~~~~~~
/build/stage/linux/drivers/base/regmap/regmap-irq.c:914:59: note: each undeclared identifier is reported only once for each function it appears in
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-05-14 9:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 9:14 [PATCH v8 00/11] Add support for MAX7360 Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 01/11] dt-bindings: mfd: gpio: Add MAX7360 Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 02/11] mfd: Add max7360 support mathieu.dubois-briand
2025-05-09 9:29 ` Christophe JAILLET
2025-05-09 9:53 ` Mathieu Dubois-Briand
2025-05-12 9:21 ` Andy Shevchenko
2025-05-13 8:25 ` Mathieu Dubois-Briand
2025-05-13 9:31 ` Lee Jones
2025-05-13 11:14 ` Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 03/11] pinctrl: Add MAX7360 pinctrl driver Mathieu Dubois-Briand
2025-05-12 9:16 ` Andy Shevchenko
2025-05-09 9:14 ` [PATCH v8 04/11] pwm: max7360: Add MAX7360 PWM support mathieu.dubois-briand
2025-05-13 10:08 ` Uwe Kleine-König
2025-05-15 7:14 ` Mathieu Dubois-Briand
2025-05-16 12:57 ` Mathieu Dubois-Briand
2025-05-19 13:13 ` Andy Shevchenko
2025-05-09 9:14 ` [PATCH v8 05/11] regmap: irq: Add support for chips without separate IRQ status Mathieu Dubois-Briand
2025-05-14 9:59 ` Mark Brown [this message]
2025-05-14 11:59 ` Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 06/11] gpio: regmap: Allow to allocate regmap-irq device Mathieu Dubois-Briand
2025-05-19 13:16 ` Andy Shevchenko
2025-05-09 9:14 ` [PATCH v8 07/11] gpio: regmap: Allow to provide init_valid_mask callback Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 08/11] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2025-05-19 13:19 ` Andy Shevchenko
2025-05-20 13:33 ` Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 09/11] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 10/11] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 11/11] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
2025-05-23 15:55 ` (subset) [PATCH v8 00/11] Add support for MAX7360 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCRph9Qo7BbtTjIR@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=mwalle@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox