From: Cristian Marussi <cristian.marussi@arm.com>
To: long.yunjian@zte.com.cn
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, peng.fan@nxp.com,
justin.chen@broadcom.com, florian.fainelli@broadcom.com,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fang.yumeng@zte.com.cn,
mou.yi@zte.com.cn, ouyang.maochun@zte.com.cn,
xu.lifeng1@zte.com.cn
Subject: Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code
Date: Thu, 15 May 2025 14:59:24 +0100 [thread overview]
Message-ID: <aCXzPGvPayVyiMHG@pluto> (raw)
In-Reply-To: <20250515203855146Sn9x-Uw9Teur35mOjn41C@zte.com.cn>
On Thu, May 15, 2025 at 08:38:55PM +0800, long.yunjian@zte.com.cn wrote:
> From: Yumeng Fang <fang.yumeng@zte.com.cn>
>
Hi,
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
All true...but...if you look at the main scmi_probe() function all of these
failures are trapped at that level currently on the return path...
see the call chain from
scmi_probe()
....
ret = scmi_channels_setup(info);
...
...so your probe errors will be overridden there with a more generic message
left in debugfs at the top level.
Thanks,
Cristian
next prev parent reply other threads:[~2025-05-15 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:38 [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code long.yunjian
2025-05-15 13:16 ` Dan Carpenter
2025-05-15 13:59 ` Cristian Marussi [this message]
2025-05-16 8:02 ` Dan Carpenter
2025-05-16 15:23 ` Christophe JAILLET
2025-05-16 15:25 ` Christophe JAILLET
2025-05-21 7:59 ` long.yunjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCXzPGvPayVyiMHG@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=fang.yumeng@zte.com.cn \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=long.yunjian@zte.com.cn \
--cc=mou.yi@zte.com.cn \
--cc=ouyang.maochun@zte.com.cn \
--cc=peng.fan@nxp.com \
--cc=sudeep.holla@arm.com \
--cc=xu.lifeng1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).