linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Andrew Zaborowski <andrew.zaborowski@intel.com>,
	x86@kernel.org, linux-sgx@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	balrogg@gmail.com
Subject: Re: [PATCH v2] x86/sgx: Prevent attempts to reclaim poisoned pages
Date: Thu, 15 May 2025 19:05:15 +0200	[thread overview]
Message-ID: <aCYey1W6i7i3yPLL@gmail.com> (raw)
In-Reply-To: <448598e9-972f-4807-ba54-fc1f7e141b4f@intel.com>


* Dave Hansen <dave.hansen@intel.com> wrote:

> Thanks for sending this, Andrew!
> 
> I think I'll probably add a slightly shorter summary:
> 
> tl;dr: SGX page reclaim touches the page to copy its contents to
> secondary storage. SGX instructions do not gracefully handle machine
> checks. Despite this, the existing SGX code will try to reclaim pages
> that it _knows_ are poisoned. Avoid even trying to reclaim poisoned pages.
> 
> But otherwise it looks great:
> 
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>

Thanks, I've applied this fix to tip:x86/sgx, with the TL;DR paragraph 
added in.

Thanks,

	Ingo

  reply	other threads:[~2025-05-15 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 23:04 [PATCH v2] x86/sgx: Prevent attempts to reclaim poisoned pages Andrew Zaborowski
2025-05-15 16:27 ` Dave Hansen
2025-05-15 17:05   ` Ingo Molnar [this message]
2025-05-15 17:18 ` [tip: x86/sgx] " tip-bot2 for Andrew Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCYey1W6i7i3yPLL@gmail.com \
    --to=mingo@kernel.org \
    --cc=andrew.zaborowski@intel.com \
    --cc=balrogg@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).