linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Mario Limonciello <superm1@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Perry Yuan" <perry.yuan@amd.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Huang Rui" <ray.huang@amd.com>,
	"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"open list:AMD HETERO CORE HARDWARE FEEDBACK DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<linux-kernel@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	"open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v10 03/13] x86/msr-index: define AMD heterogeneous CPU related MSR
Date: Fri, 16 May 2025 10:46:55 +0200	[thread overview]
Message-ID: <aCb7f4ziOffNRrkd@gmail.com> (raw)
In-Reply-To: <20250515211950.3102922-4-superm1@kernel.org>


* Mario Limonciello <superm1@kernel.org> wrote:

> From: Perry Yuan <perry.yuan@amd.com>
> 
> Introduces new MSR registers for AMD hardware feedback support.
> These registers enable the system to provide workload classification
> and configuration capabilities.
> 
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  arch/x86/include/asm/msr-index.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index b7dded3c81132..8e6db9a9f53c0 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -732,6 +732,11 @@
>  #define MSR_AMD64_PERF_CNTR_GLOBAL_CTL		0xc0000301
>  #define MSR_AMD64_PERF_CNTR_GLOBAL_STATUS_CLR	0xc0000302
>  
> +/* AMD Hardware Feedback Support MSRs */
> +#define AMD_WORKLOAD_CLASS_CONFIG      0xc0000500
> +#define AMD_WORKLOAD_CLASS_ID          0xc0000501
> +#define AMD_WORKLOAD_HRST              0xc0000502

Can we follow the existing pattern of MSR_AMD64_* or MSR_AMD_* that 99% 
of the indices in this header are following?

Thanks,

	Ingo

  reply	other threads:[~2025-05-16  8:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 21:19 [PATCH v10 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2025-05-15 23:13   ` Randy Dunlap
2025-05-15 21:19 ` [PATCH v10 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 03/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2025-05-16  8:46   ` Ingo Molnar [this message]
2025-05-15 21:19 ` [PATCH v10 04/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2025-05-15 21:22   ` Randy Dunlap
2025-05-15 21:19 ` [PATCH v10 05/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 06/13] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 07/13] platform/x86: hfi: add online and offline callback support Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 08/13] platform/x86: hfi: add power management callback Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 09/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 10/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 11/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 12/13] platform/x86/amd: hfi: Add debugfs support Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 13/13] x86/itmt: Add debugfs file to show core priorities Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCb7f4ziOffNRrkd@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=gautham.shenoy@amd.com \
    --cc=hpa@zytor.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=perry.yuan@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=superm1@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).