From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540691A76BC for ; Fri, 16 May 2025 22:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747434129; cv=none; b=mG9TJm2jBJ8xq6bSWcPTkXLwi5sNj6u05NxJvymhqERAYGNylbsCtsccjfToq05zEGV8Ar8A7CP7v7BkT1rp9mWZgN+0MbDu1tGpWQHsXgP8Re26OdXW39Y/t2zLwd/nbdTH2vGYTsISTBEBfp995JOhzIoligUbRZVZPhQao4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747434129; c=relaxed/simple; bh=kONYMJEJ044G8TH598Cjlf7EWAn1NPZyS4WQgCgWhfw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nOLgeN7ZcWidUzj6cy7HGi7RltoS3IqeG3vXLAmB2XT/enOlcmwNHxmEUs06DpOvCOUuW24zjGp3LwjwqM4Cr2B9rroreO08hVOLG3UXXp0n6uooyF12o97pfcxyrS6gDsKYWTd1vuOs17g8MklbaD8b+XtvFqPEgqU3GYhOQmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cJfQPA77; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cJfQPA77" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747434128; x=1778970128; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kONYMJEJ044G8TH598Cjlf7EWAn1NPZyS4WQgCgWhfw=; b=cJfQPA77LFuBpRVI7eph1iOdow+P8Yj5EcbTbSJD9Hp0AZtSgFkC+T79 iHIXlQBFrEv1FfGOrc/46VivX/9EY4w1uL6qJcYX+iDualNUHBqCys07y z1Zc2BUmEwpEo6uuJGIdUWCTvmllNIKUUiLPLF3278TR59iV1WBGQJGMI ptrG4eYGv1Q8KYQc3i5F4ohqLY8VsZs9ILnNws2cAF+i8LSY48DPRBQKm s1/8j6XqW3tEXxZHTW6zgeG4goLSdrRKOkR8ilq5y3nIjROzZpC8ILOEG 67KIzlB6fZizivZoYQNUa9W84bB/OpE/Lq0DAxVkLjS3678QizsDF0ZiT A==; X-CSE-ConnectionGUID: vRZj7Sn8R2m62rVaA9ZZ9Q== X-CSE-MsgGUID: IEkl7AVtT4mGsEStleS9Iw== X-IronPort-AV: E=McAfee;i="6700,10204,11435"; a="53219825" X-IronPort-AV: E=Sophos;i="6.15,295,1739865600"; d="scan'208";a="53219825" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 15:22:07 -0700 X-CSE-ConnectionGUID: 4PfXNEVeSPSO2G7++83Vng== X-CSE-MsgGUID: 1joxnqDJQsmgxWHlsSO7fA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,295,1739865600"; d="scan'208";a="143934991" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 15:22:01 -0700 Date: Sat, 17 May 2025 01:21:58 +0300 From: Raag Jadav To: Alexander Usyskin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Karthik Poosa , Reuven Abliyev , Oren Weil , linux-mtd@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomas Winkler Subject: Re: [PATCH v10 02/10] mtd: intel-dg: implement region enumeration Message-ID: References: <20250515133345.2805031-1-alexander.usyskin@intel.com> <20250515133345.2805031-3-alexander.usyskin@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250515133345.2805031-3-alexander.usyskin@intel.com> On Thu, May 15, 2025 at 04:33:37PM +0300, Alexander Usyskin wrote: > In intel-dg, there is no access to the spi controller, > the information is extracted from the descriptor region. ... > +static int intel_dg_nvm_init(struct intel_dg_nvm *nvm, struct device *device) > +{ > + int ret; > + unsigned int i, n; > + u32 access_map = 0; Reverse xmas order (along with all other places) and Reviewed-by: Raag Jadav > + /* clean error register, previous errors are ignored */ > + idg_nvm_error(nvm); > + > + ret = idg_nvm_is_valid(nvm); > + if (ret) { > + dev_err(device, "The MEM is not valid %d\n", ret); > + return ret; > + } > + > + if (idg_nvm_get_access_map(nvm, &access_map)) > + return -EIO; > + > + for (i = 0, n = 0; i < nvm->nregions; i++) { > + u32 address, base, limit, region; > + u8 id = nvm->regions[i].id; > + > + address = NVM_FLREG(id); > + region = idg_nvm_read32(nvm, address); > + > + base = FIELD_GET(NVM_FREG_BASE_MASK, region) << NVM_FREG_ADDR_SHIFT; > + limit = (FIELD_GET(NVM_FREG_ADDR_MASK, region) << NVM_FREG_ADDR_SHIFT) | > + NVM_FREG_MIN_REGION_SIZE; > + > + dev_dbg(device, "[%d] %s: region: 0x%08X base: 0x%08x limit: 0x%08x\n", > + id, nvm->regions[i].name, region, base, limit); > + > + if (base >= limit || (i > 0 && limit == 0)) { > + dev_dbg(device, "[%d] %s: disabled\n", > + id, nvm->regions[i].name); > + nvm->regions[i].is_readable = 0; > + continue; > + } > + > + if (nvm->size < limit) > + nvm->size = limit; > + > + nvm->regions[i].offset = base; > + nvm->regions[i].size = limit - base + 1; > + /* No write access to descriptor; mask it out*/ > + nvm->regions[i].is_writable = idg_nvm_region_writable(access_map, id); > + > + nvm->regions[i].is_readable = idg_nvm_region_readable(access_map, id); > + dev_dbg(device, "Registered, %s id=%d offset=%lld size=%lld rd=%d wr=%d\n", > + nvm->regions[i].name, > + nvm->regions[i].id, > + nvm->regions[i].offset, > + nvm->regions[i].size, > + nvm->regions[i].is_readable, > + nvm->regions[i].is_writable); > + > + if (nvm->regions[i].is_readable) > + n++; > + } > + > + dev_dbg(device, "Registered %d regions\n", n); > + > + /* Need to add 1 to the amount of memory > + * so it is reported as an even block > + */ > + nvm->size += 1; > + > + return n; > +} > + > static void intel_dg_nvm_release(struct kref *kref) > { > struct intel_dg_nvm *nvm = container_of(kref, struct intel_dg_nvm, refcnt); > @@ -85,6 +285,12 @@ static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > goto err; > } > > + ret = intel_dg_nvm_init(nvm, device); > + if (ret < 0) { > + dev_err(device, "cannot initialize nvm %d\n", ret); > + goto err; > + } > + > dev_set_drvdata(&aux_dev->dev, nvm); > > return 0; > -- > 2.43.0 >