Re: [PATCH net-next] net: devmem: remove min_t(iter_iov_len) in sendmsg

[Stanislav Fomichev <stfomichev@gmail.com>]

On 05/17, Al Viro wrote:
> On Fri, May 16, 2025 at 05:04:31PM -0700, Stanislav Fomichev wrote:
> > iter_iov_len looks broken for UBUF. When iov_iter_advance is called
> > for UBUF, it increments iov_offset and also decrements the count.
> > This makes the iterator only go over half of the range (unless I'm
> > missing something).
> 
> What do you mean by "broken"?  iov_iter_len(from) == "how much data is
> left in that iterator".  That goes for all flavours, UBUF included...
> 
> Confused...

Right, but __ubuf_iovec.iov_len aliases with (total) count:

union {
	struct iovec __ubuf_iovec; /* { void *iov_base; size_t iov_len } */
	struct {
		union { const struct iovec *__iov; ... };
		size_t count;
	}
}

So any time we do iov_iter_advance(size) (which does iov_offset += size
and count -= size), we essentially subtract the size from count _and_
iov_len. And now, calling iter_iov_len (which does iov_len - iov_offset)
returns bogus length. I don't think that's intended or am I missing something?