Re: [PATCH net-next] net: devmem: drop iterator type check

Stanislav Fomichev
2025-05-17T04:48:37Z

On 05/16, Mina Almasry wrote:
> On Fri, May 16, 2025 at 3:54 PM Stanislav Fomichev <stfomichev@gmail.com> wrote:
> >
> > sendmsg() with a single iov becomes ITER_UBUF, sendmsg() with multiple
> > iovs becomes ITER_IOVEC. Instead of adjusting the check to include
> > ITER_UBUF, drop the check completely. The callers are guaranteed
> > to happen from system call side and we don't need to pay runtime
> > cost to verify it.
> >
> > Fixes: bd61848900bf ("net: devmem: Implement TX path")
> > Signed-off-by: Stanislav Fomichev <stfomichev@gmail.com>
>
> Looks good to me, but can we please bundle this with the fix for
> ITER_UBUF, and if possible get some test coverage in ncdevmem?

Yeah, let's see where we arrive at wrt iter_iov_len with Al.
Will repost with a selftest change.. Thanks!

---
pw-bot: cr