The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Carlos Llamas <cmllamas@google.com>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
	maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
	mllamas@google.com, surenb@google.com,
	linux-kernel@vger.kernel.org, Yeoreum Yun <yeoreun.yun@arm.com>,
	Yunseong Kim <ysk@kzalloc.com>
Subject: Re: [PATCH] driver/android/binderfs: fix race for binderfs' devices list
Date: Sat, 17 May 2025 17:24:27 +0000	[thread overview]
Message-ID: <aCjGSx2TvQdECBT9@google.com> (raw)
In-Reply-To: <20250513174719.3096063-1-yeoreum.yun@arm.com>

On Tue, May 13, 2025 at 06:47:19PM +0100, Yeoreum Yun wrote:
> binderfs' devices list is global list and can be accesed by multi-thread
> while unmount binder device.
> Since there is no proper locking, it can meet datarace problem.
> for example it's one of case reported UAF while binderfs_evict_inode()
> removes binder device:
> 
> sudo ./stress-ng --binderfs 8 --binderfs-ops 10000 -t 15 \
>   --pathological --timestamp --tz --syslog --perf --no-rand-seed \
>   --times --metrics --klog-check --status 5 -x smi -v --interrupts --change-cpu

I just found this by chance (there is a typo on my email). Note this was
already fixed here:
https://lore.kernel.org/all/20250324132427.922495-1-dmantipov@yandex.ru/

Cheers,
Carlos Llamas

  reply	other threads:[~2025-05-17 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 17:47 [PATCH] driver/android/binderfs: fix race for binderfs' devices list Yeoreum Yun
2025-05-17 17:24 ` Carlos Llamas [this message]
2025-05-19  8:15   ` Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCjGSx2TvQdECBT9@google.com \
    --to=cmllamas@google.com \
    --cc=arve@android.com \
    --cc=brauner@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=mllamas@google.com \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    --cc=yeoreum.yun@arm.com \
    --cc=yeoreun.yun@arm.com \
    --cc=ysk@kzalloc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox