From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B982206AA for ; Mon, 19 May 2025 23:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747697527; cv=none; b=a1gw7GDv0zuBHCv7TTEZ2MDBjvC4q3eHDeaSwF0Ie3Qs0nVC7WVLY+pBpdv0U1jOp28kqRmcwxCaHXEk4bka3R9RDpK4E6Z2VESpEzHwpMCCTHLK4vKQhQweZbt8bQGYJbyEB+qD2qGiJMnMrII+kf5Z/lms7AegLAO6hZa0s0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747697527; c=relaxed/simple; bh=MuZecVDV8WFQM7jhq4WavtkULWOpjeUqMx1UI6H0F2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jcNT1FW7b/V/nqekSF7RtaIHETMalYXc2loTl0yy4BKOFdmNCqF87nG97F2mcsmQCDvk3v7vFLeHpN9YPlpZKKm9VnI9794JQCLSVMwMgevvIaHCZM8ZtJMVSolpHu7I07zk4wyqwoqlx94X3IS7qVB1sopanPiAPkoOEYQBuG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=QrnPNhRF; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="QrnPNhRF" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-742c3d06de3so2470018b3a.0 for ; Mon, 19 May 2025 16:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1747697525; x=1748302325; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QOyUGS8X8xHimjiVikyyoBlw5XuU3QFPDBQZu8PO5T8=; b=QrnPNhRF2voJgX9mgJ3TxWdTCIXOY8ju90E8BZzIhPDNYpBtUY3ngn1rmYvM3GSGOC rqA4oxWY3Bm8QEoWSROOtPPPMF0mRVcHYw8qM4aQPQ7foUKK/mfUmzm7OEJ8+wJW4hqA HkWGsVn4ju/R7yBnk/jpjfZvT6Wv6tWWMjFrim+cYwKOcZl+w09/Pn9G46+o/XV9XaHt LD9gsnz6kgAd8eY0f1MDo0lje/Itj5HZpmmPCZmiICitILHEwSLlf+mZd38s2KJxA4X4 SLUglUspZuC30STtgT0AK562Awlq+axbaZrZxF7jYtaO31xO8FSzDTJb/5n1oDH2AMNr lCnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747697525; x=1748302325; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QOyUGS8X8xHimjiVikyyoBlw5XuU3QFPDBQZu8PO5T8=; b=vHKauMpzlpsIeNm37nKMJbMldKw3ZvMZc/04isHZMqfJw0afWnRoi9DXzdDp2GhTbc w78ozsiLKbfbcvCW1cLwNR5zwHFHnkYLKngQ12cFJ5/Y/9DbR9kw1gvJPYp+hiXxQ8lp tzs+sIzlDJn13Dc/HrCLL7Baios91LKs4D2qgtqI8KIsyKrJdbjvsWIO7yiWrFoPeSAJ HHDc/8d+SZoy7VgKkmubC7+zsNpu90w0fK+nafTa3beLmGWdhZeetrhzIjKgoV459BkB iBYaHjbC5PRxAsJYZ9GQ68MxkKqNlF/hlDVQxuIBEt3SMBN4zod2fVEQCWQJTCQzZclm qtOA== X-Forwarded-Encrypted: i=1; AJvYcCVoHCVHqcobUi71jrO2nS738rhudnQ+Utgh7ZRcFMy4UqIqs/r8lsKdAbb7SrCgf8c+6Ju1So1B8SwyipY=@vger.kernel.org X-Gm-Message-State: AOJu0YxcVzm2j0yE1pHL4IoAdtzzWWJk18gL+CyVXwV4SQAX0C0R/RXo ZEgTtErgH/VSKdPoai9xbEfTo2VEdILXMFVvtp2ePgvecHj6FBB5EJSOpBSeoQ+rs/U= X-Gm-Gg: ASbGncskw2jlxNLqFlFI8zzzH3nokKf43qBD8p4qRyj2a9qO29HpaPWnARidn1FG2xy 29oWPqUgQHJ7YeW2C9rA+YQqVh7yuUNeily1jh/6sQNaVxayXpJSSNWatPHNie4jWChJEdCxcLP HXWhwnv1LSzwG5B+ieZfPptkwSRuE0NUVA7/QhGZ6ZKH0MtxOr0ZeYBBaJjhg75WT8HfRWarVQO ieiVsboFPEhDdnjWzoNveUgh/gYXvAQO+xtQjTKflr6+OvN2HE9rVQkwW8UxU7a6i54Y2cekG+B Ss1Gfcp7+UTEg8/z9srUUn8bEKyZfNSb+O/QeicgBn2nn9o= X-Google-Smtp-Source: AGHT+IF/UpnfYd87Wg38QzExFJepdbUZBdK8n48P10QCBwcJgibQDw+FN+/Y6470diBydPdUYMEijg== X-Received: by 2002:a05:6a20:3d1c:b0:1ee:d418:f764 with SMTP id adf61e73a8af0-2170ce33ad3mr22022427637.38.1747697524568; Mon, 19 May 2025 16:32:04 -0700 (PDT) Received: from ghost ([2601:647:6700:64d0:5f9c:a71e:a2da:158d]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b26eb0a9893sm6875885a12.72.2025.05.19.16.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 16:32:03 -0700 (PDT) Date: Mon, 19 May 2025 16:32:01 -0700 From: Charlie Jenkins To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland , Andrew Jones , Deepak Gupta Subject: Re: [PATCH v7 09/14] riscv: misaligned: move emulated access uniformity check in a function Message-ID: References: <20250515082217.433227-1-cleger@rivosinc.com> <20250515082217.433227-10-cleger@rivosinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250515082217.433227-10-cleger@rivosinc.com> On Thu, May 15, 2025 at 10:22:10AM +0200, Clément Léger wrote: > Split the code that check for the uniformity of misaligned accesses > performance on all cpus from check_unaligned_access_emulated_all_cpus() > to its own function which will be used for delegation check. No > functional changes intended. > > Signed-off-by: Clément Léger > Reviewed-by: Andrew Jones > --- > arch/riscv/kernel/traps_misaligned.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c > index e551ba17f557..287ec37021c8 100644 > --- a/arch/riscv/kernel/traps_misaligned.c > +++ b/arch/riscv/kernel/traps_misaligned.c > @@ -647,6 +647,18 @@ bool __init check_vector_unaligned_access_emulated_all_cpus(void) > } > #endif > > +static bool all_cpus_unaligned_scalar_access_emulated(void) > +{ > + int cpu; > + > + for_each_online_cpu(cpu) > + if (per_cpu(misaligned_access_speed, cpu) != misaligned_access_speed is only defined when CONFIG_RISCV_SCALAR_MISALIGNED. This function should return false when !CONFIG_RISCV_SCALAR_MISALIGNED and only use this logic otherwise. - Charlie > + RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED) > + return false; > + > + return true; > +} > + > #ifdef CONFIG_RISCV_SCALAR_MISALIGNED > > static bool unaligned_ctl __read_mostly; > @@ -685,8 +697,6 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu) > > bool __init check_unaligned_access_emulated_all_cpus(void) > { > - int cpu; > - > /* > * We can only support PR_UNALIGN controls if all CPUs have misaligned > * accesses emulated since tasks requesting such control can run on any > @@ -694,10 +704,8 @@ bool __init check_unaligned_access_emulated_all_cpus(void) > */ > on_each_cpu(check_unaligned_access_emulated, NULL, 1); > > - for_each_online_cpu(cpu) > - if (per_cpu(misaligned_access_speed, cpu) > - != RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED) > - return false; > + if (!all_cpus_unaligned_scalar_access_emulated()) > + return false; > > unaligned_ctl = true; > return true; > -- > 2.49.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv