From: Richard Cochran <richardcochran@gmail.com>
To: Jeongjun Park <aha310510@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, yangbo.lu@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: remove ptp->n_vclocks check logic in ptp_vclock_in_use()
Date: Tue, 20 May 2025 06:15:29 -0700 [thread overview]
Message-ID: <aCyAcbNqKRlPnadx@hoboy.vegasvil.org> (raw)
In-Reply-To: <20250519153735.66940-1-aha310510@gmail.com>
On Tue, May 20, 2025 at 12:37:35AM +0900, Jeongjun Park wrote:
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index 35a5994bf64f..0ae9f074fc52 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -412,9 +412,8 @@ static int unregister_vclock(struct device *dev, void *data)
>
> int ptp_clock_unregister(struct ptp_clock *ptp)
> {
> - if (ptp_vclock_in_use(ptp)) {
> + if (ptp_vclock_in_use(ptp))
> device_for_each_child(&ptp->dev, NULL, unregister_vclock);
> - }
>
> ptp->defunct = 1;
> wake_up_interruptible(&ptp->tsev_wq);
This hunk is not related to the subject of the patch. Please remove it.
Thanks,
Richard
next prev parent reply other threads:[~2025-05-20 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 15:37 [PATCH] ptp: remove ptp->n_vclocks check logic in ptp_vclock_in_use() Jeongjun Park
2025-05-20 13:15 ` Richard Cochran [this message]
2025-05-20 14:17 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCyAcbNqKRlPnadx@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=aha310510@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox