From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B7A255227; Tue, 20 May 2025 22:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747778562; cv=none; b=pMSX2CRFFNv25V51g5W/B+d1DTEiPFqYgWsd80ekw/EvW0wJdaiywmTGKwV+GUuzoTQPg2Ts5FGE4PdiN6iBF2OwlxBYzLgcYaBRXg7+f8QHqm5+ur85u/DAIARrP5OAxH+LSCl8AExodRiyfzzniVKWAiqHRK49UlMIZgAKeJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747778562; c=relaxed/simple; bh=ANtapAnA3Ce5KZ8i8qQUgB9zrNU8S7iRnHX8Mr2B8wk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AtpuxFNm2T1rdYngXkQajjXWWfmKdZoGNKsu1WJCZ+0aX2oAYzXkFoHUviZF+Oup1t7faLok6mvwz//WzD6JEYrVspLA786zpaiz7CdXU1MY5YtApDqG4poXMVV2hTKSNCSyJS5dcrDgIXvpMRAiY6pyZXCucdevx0gMEw7Z/Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OZzf82Sa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OZzf82Sa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5CEFC4CEE9; Tue, 20 May 2025 22:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747778562; bh=ANtapAnA3Ce5KZ8i8qQUgB9zrNU8S7iRnHX8Mr2B8wk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OZzf82Sa738tC5R8nor2Op30+UjqD71FQCzjRPpIOWxzzXGwNEHTl5PtcB8aXCfcS AkYNPw9u+CDAbBeOyCHqa9/xVIQy1kQQ22TdP0iZhiYran1GfWnYAPMD+T/i99sb2U vodpyGofNuTvHs3Pk4ZUysGW6GwKwsSOEgmdy9Rbz2y32gbvSdOyhTs2kkNS4yfSI+ w6JKzD9xez9kRmVQ3wpTaFD5xWqEnD8wDjAoHOS7pLCJU3ehUPlSblZmNbNBHqyijK gGQgPsMvah9jMHWNtGiDzIQ5NOJ6hvAijASeBTfBnxkRNHE4GhnSGCZCnOYMdXqmfG 1BgDSp/rmZF4A== Date: Tue, 20 May 2025 15:02:40 -0700 From: Namhyung Kim To: kan.liang@linux.intel.com Cc: peterz@infradead.org, mingo@redhat.com, irogers@google.com, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, eranian@google.com, ctshao@google.com, tmricht@linux.ibm.com, leo.yan@arm.com Subject: Re: [PATCH V4 02/16] perf: Only dump the throttle log for the leader Message-ID: References: <20250520181644.2673067-1-kan.liang@linux.intel.com> <20250520181644.2673067-3-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250520181644.2673067-3-kan.liang@linux.intel.com> On Tue, May 20, 2025 at 11:16:30AM -0700, kan.liang@linux.intel.com wrote: > From: Kan Liang > > The PERF_RECORD_THROTTLE records are dumped for all throttled events. > It's not necessary for group events, which are throttled altogether. > > Optimize it by only dump the throttle log for the leader. > > The sample right after the THROTTLE record must be generated by the > actual target event. It is good enough for the perf tool to locate the > actual target event. > > Suggested-by: Namhyung Kim > Signed-off-by: Kan Liang Acked-by: Namhyung Kim Thanks, Namhyung > --- > kernel/events/core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 915698f47682..cd559501cfbd 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -2744,14 +2744,16 @@ static void perf_event_unthrottle(struct perf_event *event, bool start) > event->hw.interrupts = 0; > if (start) > event->pmu->start(event, 0); > - perf_log_throttle(event, 1); > + if (event == event->group_leader) > + perf_log_throttle(event, 1); > } > > static void perf_event_throttle(struct perf_event *event) > { > event->pmu->stop(event, 0); > event->hw.interrupts = MAX_INTERRUPTS; > - perf_log_throttle(event, 0); > + if (event == event->group_leader) > + perf_log_throttle(event, 0); > } > > static void perf_event_unthrottle_group(struct perf_event *event, bool skip_start_event) > -- > 2.38.1 >