Re: [PATCH 2/6] dt-bindings: i2c: renesas,riic: Document RZ/T2H support

Geert Uytterhoeven
2025-06-06T13:21:46Z

Hi Prabhakar,

On Fri, 30 May 2025 at 16:31, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Document support for the I2C Bus Interface (RIIC) found on the Renesas
> RZ/T2H (R9A09G077) SoC. The RIIC IP on this SoC is similar to that on
> the RZ/V2H(P) SoC but supports fewer interrupts, lacks FM+ support and
> does not require resets. Due to these differences, add a new compatible
> string `renesas,riic-r9a09g077` for the RZ/T2H SoC.
>
> Unlike earlier SoCs that use eight distinct interrupts, the RZ/T2H uses
> only four, including a combined error/event interrupt. Update the binding
> schema to reflect this interrupt layout and skip the `resets` property
> check, as it is not required on these SoCs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> @@ -29,32 +29,46 @@ properties:
> - renesas,riic-r9a09g056 # RZ/V2N
> - const: renesas,riic-r9a09g057 # RZ/V2H(P)
>
> - - const: renesas,riic-r9a09g057 # RZ/V2H(P)
> + - enum:
> + - renesas,riic-r9a09g057 # RZ/V2H(P)
> + - renesas,riic-r9a09g077 # RZ/T2H
>
> reg:
> maxItems: 1
>
> interrupts:
> - items:
> - - description: Transmit End Interrupt
> - - description: Receive Data Full Interrupt
> - - description: Transmit Data Empty Interrupt
> - - description: Stop Condition Detection Interrupt
> - - description: Start Condition Detection Interrupt
> - - description: NACK Reception Interrupt
> - - description: Arbitration-Lost Interrupt
> - - description: Timeout Interrupt
> + oneOf:
> + - items:
> + - description: Transmit End Interrupt
> + - description: Receive Data Full Interrupt
> + - description: Transmit Data Empty Interrupt
> + - description: Stop Condition Detection Interrupt
> + - description: Start Condition Detection Interrupt
> + - description: NACK Reception Interrupt
> + - description: Arbitration-Lost Interrupt
> + - description: Timeout Interrupt
> + - items:
> + - description: Transmit End Interrupt
> + - description: Receive Data Full Interrupt
> + - description: Transmit Data Empty Interrupt
> + - description: Transmit error or event Interrupt

Nit: the documentation calls it "Transfer error or event generation".

>
> interrupt-names:
> - items:
> - - const: tei
> - - const: ri
> - - const: ti
> - - const: spi
> - - const: sti
> - - const: naki
> - - const: ali
> - - const: tmoi
> + oneOf:
> + - items:
> + - const: tei
> + - const: ri
> + - const: ti
> + - const: spi
> + - const: sti
> + - const: naki
> + - const: ali
> + - const: tmoi
> + - items:
> + - const: tei
> + - const: ri
> + - const: ti

Given you have a new set of names, perhaps "rxi" and "txi",
to match the documentation?

> + - const: eei

Perhaps use the order from the documentation: eei, rxi, txi, tei?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds