Re: [PATCH v2 1/7] dt-bindings: pinctrl: rockchip: increase max amount of device functions

Nicolas Frattaroli
2025-06-05T14:35:52Z

On Thursday, 5 June 2025 15:29:03 Central European Summer Time Linus Walleij wrote:
> On Mon, Jun 2, 2025 at 6:20 PM Nicolas Frattaroli
> <nicolas.frattaroli@collabora.com> wrote:
>
> > With the introduction of the RK3576, the maximum device function ID used
> > increased to 14, as anyone can easily verify for themselves with:
> >
> > rg -g '*-pinctrl.dtsi' '<\d+\s+RK_P..\s+(?<func>\d+)\s.*>;$' --trim \
> > -NI -r '$func' arch/arm64/boot/dts/rockchip/ | sort -g | uniq
> >
> > Unfortunately, this wasn't caught by dt-validate as those pins are
> > omit-if-no-ref and we had no reference to them in any tree so far.
> >
> > Once again kick the can down the road by increasing the limit to 14.
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Is this something I can just apply?
>
> Yours,
> Linus Walleij
>

Absolutely, there's no harm in it landing early, and is only tangentially
related to the rest of the series because it came up while I was pinmuxing
my PWM pins.

Kind regards,
Nicolas Frattaroli