From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C070CA937 for ; Tue, 3 Jun 2025 17:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748972931; cv=none; b=XAkT9hhTKANdE6BOTLvD8EzRVYlMnhMrF+dVbVfwhtN262TMWi7ZNzqAMN87OFXgotQVBq5ATdwt+ksndQNCsAiAMyOxwtcYtVi5hT6tZ+eYLpdg5jm3RYXResl9iByoCHn57cnI+D4XHDlrrnLa+Vp4ZoF6HlycTG1nd5QzIow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748972931; c=relaxed/simple; bh=eEBuMoSNI7au+HNe76KotnFGWKYETVSxnFoLxaa7t74=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QJR+T33+v0fXypW8wptVrlCilzZm7Yp2xVMb/yoiSlo1z2+jfUlFQc1u4sb3mWP68UfcSHKrpK4aQh6NnnOj17yETN8Q3MPTm+lTPNoECj9uSCFITTyZxckErmUOT8GLaNZYKKsIgQ4Hqf2Z+gbIiViIEhHOuiP1fDVZj8BJ5bY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=duz1kGW7; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="duz1kGW7" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-23539a1a421so32529575ad.0 for ; Tue, 03 Jun 2025 10:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748972929; x=1749577729; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AZQvVO8nyC+ZKLyjCrtVBxSwB/yFvzMpPXbPJR/HF0A=; b=duz1kGW7PAtnkdkfCcjOIelyryshY4G4Jm2w3ktysiA1PSI00KLpQNpyKAJ8/Jg3ls byNUdz8Drt00ALRWVJmYZNV1RgK9AYtu1BtOswL6Bq5OlZ6WySPNW5C+bBCaDVR9tJyj SlVyrrKyYqaAq6mQpBbUBMDuYNr1Y0KFDG2i5HDmGDSfwilzchLn8mXT3PVkEIr+SOUa C3BNkvrbs5f0ycMCsgjEabxFCjW4HD29R35ZCzVXCkJUNxxWz6t0FVfI45fyzgl3IDaK twLNFPop8zJa7RIDY1inon6rGtViA5UmlMCDC9VhmrGzhoBH4vloCqHoQXTV1jyziYB8 dVHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748972929; x=1749577729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AZQvVO8nyC+ZKLyjCrtVBxSwB/yFvzMpPXbPJR/HF0A=; b=mmwBl5YWjRKpSja3D9dLlQ0OqAy46dSq2iIqwA8Wzi43TIDoSpOGHcHUcPyPgg7LR4 C9Ng7Q9qqZlOlDXxpKEP4SVMt326FqNO8qEZwUUorHbdfd2pueU2GGBaudurrWGrDgoZ UDzdo3RZLs3CZty2eNcLY0owLAbOn3Oyfr22JeZAuJIUZpu6ZC4UpT6TdWzmOryvC1vT SnkvXFMKNE/t+VuWpZM9T/oGLkqVYqsioX+e/V+ZTDIU3lImK3tlvsLziZNtv9mfFuwu 1kcjkQvtwKkloLgQxwMENfiYULLXnz8l2Lf0w5TYGPHjhWcljcNe/aeEDYWAV3NpZ3ZE /xcg== X-Forwarded-Encrypted: i=1; AJvYcCVFGnXmQOin3AbpfV4TYsw2tek14v5yk1QIfcnvobXod3n4EiPezlii3Vz/KwRIxfIxr2o7GV1gF3IzsZk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3wQhHnhJeYNyat+xZRlS/i+UKD2cPUw9ju4n1ok53W0SVIQm5 rW7xoWctuPEmFYqcIIaE6lVqlmVkols/EAMaoY+vFISimFbT7eRKleTWTaMwSLapeA== X-Gm-Gg: ASbGncsZd0z1pbDuXA7I9N1BEIRkUod5CVko4XQQGI6nSbOSb7UbFOXHwJ4y5zDpjbB /v02jcTDyL51kYJ5tmMS10so8zDNOblfKMEKE8D/LXCX1rUY4V2OxOweDbTfPBE4kiFb7VXZNd2 HjF8YfQLknVuSwbYL5XSWtC+h9o+C7VC/ZtaYCxCXRqiAr+hDfMu4k/lUfxiH8S26rLU4mCLo2C lbZh5SBjEBstTIzCgyXu1akO25EU7hRbQRTaADZUGVi9nUsxrjXDxN3raMysJF4q81iz5mrb8KA Gw6Axx5UnYd2DM5pEMxabs+GPAwciJGgDALDgO+wyMUQJMQ3dLLIovUaRD/dJcBbewTrb3VD732 Yrej4Q4arfvkuQlbLdD3DPLc6GkQ= X-Google-Smtp-Source: AGHT+IFw/hM9KjB2+YIvlfPv7TCR6YjgHHZTSPyy4qbS7jSH9/Uc2dPgZocX8nOAauHg/zfpx7Iegw== X-Received: by 2002:a17:903:234f:b0:234:98eb:8eda with SMTP id d9443c01a7336-2355f762d1amr220323805ad.28.1748972928721; Tue, 03 Jun 2025 10:48:48 -0700 (PDT) Received: from google.com (128.65.83.34.bc.googleusercontent.com. [34.83.65.128]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506bc95fcsm89801555ad.11.2025.06.03.10.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 10:48:48 -0700 (PDT) Date: Tue, 3 Jun 2025 10:48:44 -0700 From: William McVicker To: Daniel Lezcano Cc: tglx@linutronix.de, Jim Cromie , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , "Peter Zijlstra (Intel)" , Marco Elver , Nam Cao , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, John Stulz , Peter Griffin , Saravan Kanna Subject: Re: [PATCH v1 1/7] clocksource/drivers/scx200: Add module owner Message-ID: References: <20250602151853.1942521-1-daniel.lezcano@linaro.org> <20250602151853.1942521-2-daniel.lezcano@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250602151853.1942521-2-daniel.lezcano@linaro.org> On 06/02/2025, Daniel Lezcano wrote: > The conversion to modules requires a correct handling of the module > refcount in order to prevent to unload it if it is in use. That is > especially true with the clockevents where there is no function to > unregister them. > > The core time framework correctly handles the module refcount with the > different clocksource and clockevents if the module owner is set. > > Add the module owner to make sure the core framework will prevent > stupid things happening when the driver will be converted into a > module. > > Signed-off-by: Daniel Lezcano Reviewed-by: Will McVicker Thanks, Will > --- > drivers/clocksource/scx200_hrt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/scx200_hrt.c b/drivers/clocksource/scx200_hrt.c > index c3536fffbe9a..5a99801a1657 100644 > --- a/drivers/clocksource/scx200_hrt.c > +++ b/drivers/clocksource/scx200_hrt.c > @@ -52,6 +52,7 @@ static struct clocksource cs_hrt = { > .mask = CLOCKSOURCE_MASK(32), > .flags = CLOCK_SOURCE_IS_CONTINUOUS, > /* mult, shift are set based on mhz27 flag */ > + .owner = THIS_MODULE, > }; > > static int __init init_hrt_clocksource(void) > -- > 2.43.0 >