From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EFAB10A3E for ; Fri, 23 May 2025 06:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747983307; cv=none; b=L1O/QO3dWPNBq3MA+xi7S2Z5KYfM3ZIF5NJciWLaiq4E5ryhXx5Hb19kxv09LHp1XbWzsi6KyaYQrGCAV3WBZN3On2YqTwfJmCPHIwGMobDK6/B3/cuEMTclCjAEMKsFEyPpBxptEoXjT5Tm+lPs4LOJnkPXKG3RGwSfh9UItjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747983307; c=relaxed/simple; bh=U20oBW7Rv6lgEPsP0GX95por6oX52DQoUY7ib1Yx1bc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BBrecQT5XPh+VVpwcG2lgXbSdZe1P9aBuFlCgEI/dEZEGgB47Px0vT9dsM7BW6UxBGf0vPYVa5HKdZOQX4spsIhBErppYWodjsrrK99sIFtHUtntfUct+7a95vngxYfGTFRcRU4VFS+bo1tdVLQ4ZkDjpPjmRDr4WUlDnFGvQFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f59BtNMF; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f59BtNMF" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a361b8a664so6853722f8f.3 for ; Thu, 22 May 2025 23:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747983303; x=1748588103; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=69oCtQFtFuIhATn7nt7tT3JoQ8RLcM/FthzOv16zp9Y=; b=f59BtNMFez59EXrzk3AfHvpLLVZp8dVZqJD/sC5KP9jgnljUNZd2XQDXOYLrYcctWY qTgPc01LYuW5HRRi9oqmQHc9Ixcl6HIlCzF/IeUJg+QlOxDNwJPQxhwNTeIpJZsSjUVt LFuYgi4Mw6tqf6TNOKohDWb3nOyCrQGzc+UOLAQZIu4uQuCX6IKSvtRIO02XO6NMCM0m lVufifWZ1Vs0vDEPBZplJnzRV6+BFKUX36rQzAOoscHgnk22T+TeFlmaic7YAb3+QQyb 3AZnA9WFPzP28ujsY9CfvZLNgG15ddhn8WKhZUZDZBrQprmD3qIGGdQHJ/yM8IXCgusM Wz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747983303; x=1748588103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=69oCtQFtFuIhATn7nt7tT3JoQ8RLcM/FthzOv16zp9Y=; b=cn9fI5lWAKrxqtFpmjO69p+5VGj/rl3CK9zefjx1ybyfQwDYL/ZvtvFOJ9O2bG+Qc6 lVISBwfrXN6jDyAOgcoFlTHbdBTcaxnOIsLk8mhBgy5wrF+DK8pa2EUGasRqBw+0GPGy g25Ea/3L2zna1wF2QiKfVMDUGkkhQP9I5S+Nu9FP2U53+XXnbYTM4zEVVV63S7IWoRdj 3IqIpQy7uLf6KMhzc9qvxs+AlzBn3OPGtJ1TPtfiFrEmfA4n50878k0scOvhXzHZ3Uw9 G9VZP34bfNeG9b850bSwJRJ+2NHG4BW/Q2V09bzfzrkvR8W9Xki6oaKzDbO9OHNFSCqj VlIw== X-Forwarded-Encrypted: i=1; AJvYcCW4hKTSUILeLsaWAekKwodoXohfqkVpm8EpX4k9AooBMZMidfddEjgruJKkuX8Brk+Q1uH5bwd4TYq3EQc=@vger.kernel.org X-Gm-Message-State: AOJu0YyF1Bz2JxhnZcgUyEGBP0IOgKH9gIyhXWA68qa/8sHjObA8FT4/ Pj0x4kofAAY4So6cPRnzwqUYDCH9CKjIEBNhRPo/P9Rw5HbznRX2o0Yamrk2MCTAcno= X-Gm-Gg: ASbGncv8CcvIL0nGwF4cj2seEnKxjrV7eaJOnj4rEvJ7SY54ZzXpyi9AeRjwrV3T8dz sDIBCukOiaU5J9mUIIbn++v2XU+r1cfFRzYYbnMnK94OkxjCbn/3/XnXBSODQH1Vn0lb9UneDbj oNAligO/63iMUKC+fec8qc5AjJPv8p6dc8GfleFlmLlQ/YqCmc0M6iKjOLlpUKulNyHKrSN8LXA ySn8K0bslJLQ4/Z8E/hfZe+jo4g4bXzhwI08EinfGeyqFDA0FhdluqiK7A2LsbWubW/miCgNHSH Cd+iGEI+Gqqt/o2ZnZi/i8w/3p/+weTnExc6XZT1hw/WIbGO X-Google-Smtp-Source: AGHT+IH75aOsRJMnyheDQH5VfJc94Xc0jentcmMf8E7Zp2ROIEwHjqRlngeR8WzATqUqYD8xScblVw== X-Received: by 2002:a05:6000:2903:b0:3a3:6e62:d8d5 with SMTP id ffacd0b85a97d-3a36e62d9afmr15906729f8f.58.1747983303480; Thu, 22 May 2025 23:55:03 -0700 (PDT) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca88941sm25904629f8f.61.2025.05.22.23.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 23:55:02 -0700 (PDT) Date: Fri, 23 May 2025 09:55:00 +0300 From: Abel Vesa To: Krzysztof Kozlowski Cc: Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , Dmitry Baryshkov , Rob Clark , Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , linux-clk@vger.kernel.org, Srinivas Kandagatla , Dmitry Baryshkov Subject: Re: [PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU Message-ID: References: <20250430-b4-sm8750-display-v5-0-8cab30c3e4df@linaro.org> <20250430-b4-sm8750-display-v5-21-8cab30c3e4df@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250430-b4-sm8750-display-v5-21-8cab30c3e4df@linaro.org> On 25-04-30 15:00:51, Krzysztof Kozlowski wrote: > v12.0 DPU on SM8750 comes with 10-bit color alpha. Add register > differences and new implementations of setup_alpha_out(), > setup_border_color() and setup_blend_config(). > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes in v4: > 1. Lowercase hex, use spaces for define indentation > 2. _dpu_crtc_setup_blend_cfg(): pass mdss_ver instead of ctl > > Changes in v3: > 1. New patch, split from previous big DPU v12.0. > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 19 ++++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 84 +++++++++++++++++++++++++++++-- > 2 files changed, 94 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index a4b0fe0d9899b32141928f0b6a16503a49b3c27a..90f47fc15ee5708795701d78a1380f4ab01c1427 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -320,14 +320,20 @@ static bool dpu_crtc_get_scanout_position(struct drm_crtc *crtc, > } > > static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, > - struct dpu_plane_state *pstate, const struct msm_format *format) > + struct dpu_plane_state *pstate, > + const struct msm_format *format, > + const struct dpu_mdss_version *mdss_ver) > { > struct dpu_hw_mixer *lm = mixer->hw_lm; > uint32_t blend_op; > - uint32_t fg_alpha, bg_alpha; > + uint32_t fg_alpha, bg_alpha, max_alpha; > > fg_alpha = pstate->base.alpha >> 8; For the 10-bit alpha, you need to shift here by 5 instead of 8.