From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F056B13EFE3 for ; Fri, 23 May 2025 07:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747983729; cv=none; b=Dy/EVv71M94dH0ldVCjMy/2JXd2eh9vIyghj636z0wVl2PWHBfKFEnMrUWAbyIXRn+6WR8bm1FSWcszWGBmwWL/SJhDTaLXdUnVkoa+IQPbxV1/ILctGx66dX7nw/YtMUnnvqGxnPRg/u0An2OH2KMSOAeApPvZ6EUv9ERnbHgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747983729; c=relaxed/simple; bh=c7jysfuRbmmTUAzBorXcjsX2IBCdoM9L94JM9I+9q8Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FCmJMKFyby7+go2D2XwyFOeSsuJGsO6RCxig5hvq1pcCyFGwyVHpy9+xIRGljq7q3XCQFuQddesUq+4HK9TcyYcEC+i1Q+c/n7jvpL85zfwJJH+CevAWlBrOhwXPJW5PoDYsZhvf2TbRyci05JeQse7Zfqz8ApDpf35yDz8hIfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HHJpvCtl; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HHJpvCtl" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-442ed8a275fso111018415e9.2 for ; Fri, 23 May 2025 00:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747983726; x=1748588526; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y3chgsoPjsxPJjeKJHvKUZQo0VoemKGDA7Ek6bDVj68=; b=HHJpvCtlXa2x9a/S3RFf0ofBB22Jy+vGXphOTfZ8UE7MdcxZTgulODBAOO24SC+txI xMygkZTxiyRslE9sSZMeq1wS6Gjbuutsr7iWWquu2yksqaAB1mKGdLrsNcmQznPpN9wL qbRTfhwUhapFsmZy/weuOD0HY6lC+2E2QCQuTI4OlkNRU0/pd9Aja5VToHfqQa9l2qbz OWLoXGqQ44K9h8k18zzc3k4/Ot1AOxLEg05i5IusYM2bf+0Pn/cHmZrJQL0NuzRfD98v a+XCPhpknVjB0IEf9Bp9iOhZ6doyAi44+ZY+By4J21/7pqruFVBUobUPQ55/6I9O0/3p zg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747983726; x=1748588526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y3chgsoPjsxPJjeKJHvKUZQo0VoemKGDA7Ek6bDVj68=; b=LSDUOghqeErAJXGTeJq1MV4cZfhR8bAR+mh6m2hLa/CPo/cXrkl8SkGTW21mFiljFi aJwMPVWBc7gTZNcQ1EFJJgAtpsu4Qkn4Mb3+Jh8ky7Z1bPgC2MR1MiQu7E7I/W1yaDsp QrBVs2XvlZRkAC/N5v2gNJu+8xdMOhosvVj7CeQ5VjucbxosGAmnk6nsHHHgzVD9utha IeTyuYA1HNdVKUMiPVz0+TlF1iXv7j4PK35WIMJrB8KwpKrq3Xy0yipmBLeVALfv4xvx 4HjD5faipf75J0z9Ct1//HaPu2qfa6yFBn/Rhk9h0y+buVMlXuj/r9phQuf0ZjqfdmRM lSHQ== X-Forwarded-Encrypted: i=1; AJvYcCVe+DPcMKM7O3682+E28IdrH8B3nw2Vlf6FYHKjEjHwyCAM6NWTqnrxDMRBZhAFGKiqyx2QdKUmnEFrMec=@vger.kernel.org X-Gm-Message-State: AOJu0YxG+UvQqcRVrQXWAQ7HBUxwIAz3gv1361F/vTKTz+HVth4I1HQN YV73ZsyDfoMgIVz7pHhgMOLChCITBiJoeqeIdyrGNNg5IA0mFfw19DsyO/sC8+o69gM= X-Gm-Gg: ASbGncsleEOK+ezYLPxzWC0scuTPBVkgAVybtJq4LadqoYwhnGClZRsCSspq/zPKxb2 r1R+XixCXvNlneFaL42t3Sa3fAKOyFE6JldBpY2dd42pOgQ1E/7lLjlSokFqhO11JnG+Dh5COU7 Mpc+Ivqi/GPGazMJBmYD8SY1UhR2cHiQy04hOTZHyMgfO42mNbU+I/h/TUG6u4xTpgtjfF2qbJc JJbqmp8cntMuwwYkzK/8KpK870q6XEFyyeoI81BKfHjc6ODWMikPDDAitd8ffVKOIg51VH3apZ3 p/nEjPsBboY5KYaOQ3ksN2rOLg6YrPsI/EownQ/sLDS7ZoC/ X-Google-Smtp-Source: AGHT+IFY4y/ZUB1VKe4lNbsorjCqofEy8Oz5r/Dj6XfZyxk0qjzrM+uoTb7F1fSElFjmjBLoR4SC6w== X-Received: by 2002:a05:600c:8487:b0:43d:160:cd9e with SMTP id 5b1f17b1804b1-44b6d6b1fdbmr13812575e9.17.1747983726219; Fri, 23 May 2025 00:02:06 -0700 (PDT) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f18251adsm134886385e9.2.2025.05.23.00.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 00:02:05 -0700 (PDT) Date: Fri, 23 May 2025 10:02:03 +0300 From: Abel Vesa To: Krzysztof Kozlowski Cc: Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , Dmitry Baryshkov , Rob Clark , Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , linux-clk@vger.kernel.org, Srinivas Kandagatla , Dmitry Baryshkov Subject: Re: [PATCH v5 21/24] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU Message-ID: References: <20250430-b4-sm8750-display-v5-0-8cab30c3e4df@linaro.org> <20250430-b4-sm8750-display-v5-21-8cab30c3e4df@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 25-05-23 09:55:00, Abel Vesa wrote: > On 25-04-30 15:00:51, Krzysztof Kozlowski wrote: > > v12.0 DPU on SM8750 comes with 10-bit color alpha. Add register > > differences and new implementations of setup_alpha_out(), > > setup_border_color() and setup_blend_config(). > > > > Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes in v4: > > 1. Lowercase hex, use spaces for define indentation > > 2. _dpu_crtc_setup_blend_cfg(): pass mdss_ver instead of ctl > > > > Changes in v3: > > 1. New patch, split from previous big DPU v12.0. > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 19 ++++--- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 84 +++++++++++++++++++++++++++++-- > > 2 files changed, 94 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > > index a4b0fe0d9899b32141928f0b6a16503a49b3c27a..90f47fc15ee5708795701d78a1380f4ab01c1427 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > > @@ -320,14 +320,20 @@ static bool dpu_crtc_get_scanout_position(struct drm_crtc *crtc, > > } > > > > static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, > > - struct dpu_plane_state *pstate, const struct msm_format *format) > > + struct dpu_plane_state *pstate, > > + const struct msm_format *format, > > + const struct dpu_mdss_version *mdss_ver) > > { > > struct dpu_hw_mixer *lm = mixer->hw_lm; > > uint32_t blend_op; > > - uint32_t fg_alpha, bg_alpha; > > + uint32_t fg_alpha, bg_alpha, max_alpha; > > > > fg_alpha = pstate->base.alpha >> 8; > > For the 10-bit alpha, you need to shift here by 5 instead of 8. Typo. "6 instead of 8". I blame the keyboard ...