Re: [GIT PULL] platform-drivers-x86 for v6.16-1

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

Hi!

> warning to hid-asus. I'm expecting Pavel might want object the approach
> used in the tuxedo driver, I largely relied on my co-maintainer Hans'
> opinion on what to do with that change as he was much more familiar with
> that discussion, and the pros and cons of each approach.


>  drivers/platform/x86/tuxedo/nb04/wmi_ab.c          |  923 +++++
>  drivers/platform/x86/tuxedo/nb04/wmi_util.c        |   91 +
>  drivers/platform/x86/tuxedo/nb04/wmi_util.h        |  109 +

Yes, I'd preffer this not to go in.

Reasons:

1) Normally, keyboard backlight is handled by LED subsystem. This was
not even Cc-ed to LED list.

2) It introduces new kernel API. Unfortunately, that API is not
documented in the kernel and is very much unlike anything else we have
in the kernel.

3) The code is not modular in any way, so the crazy API code is mixed
with real driver code, making reuse hard.

4) We don't have reasonable support for the new API in the userland.

Please take a look.

Best regards,
								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]