> In all the MUX value for LED1 GPIO46 there is a Copy-Paste error where > the MUX value is set to LED0_MODE_MASK instead of LED1_MODE_MASK. > > This wasn't notice as there were no board that made use of the > secondary PHY LED but looking at the internal Documentation the actual > value should be LED1_MODE_MASK similar to the other GPIO entry. > > Fix the wrong value to apply the correct MUX configuration. Acked-by: Lorenzo Bianconi > > Cc: stable@vger.kernel.org > Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC") > Signed-off-by: Christian Marangi > --- > drivers/pinctrl/mediatek/pinctrl-airoha.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c > index b97b28ebb37a..8ef7f88477aa 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c > +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c > @@ -1752,8 +1752,8 @@ static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > @@ -1816,8 +1816,8 @@ static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > @@ -1880,8 +1880,8 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > @@ -1944,8 +1944,8 @@ static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = { > .regmap[0] = { > AIROHA_FUNC_MUX, > REG_GPIO_2ND_I2C_MODE, > - GPIO_LAN3_LED0_MODE_MASK, > - GPIO_LAN3_LED0_MODE_MASK > + GPIO_LAN3_LED1_MODE_MASK, > + GPIO_LAN3_LED1_MODE_MASK > }, > .regmap[1] = { > AIROHA_FUNC_MUX, > -- > 2.48.1 >