From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Matthew Brost" <matthew.brost@intel.com>,
"Himal Prasad Ghimiray" <himal.prasad.ghimiray@intel.com>,
"Imre Deak" <imre.deak@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency
Date: Wed, 28 May 2025 12:34:43 +0300 [thread overview]
Message-ID: <aDbYs7QZRfr2i80A@smile.fi.intel.com> (raw)
In-Reply-To: <j7yodlrk7wh3ylvb2z622ndlzm4guhahmakdb6l5d6qtv5sabo@w4bfiehtmaab>
On Tue, May 27, 2025 at 03:55:46PM -0500, Lucas De Marchi wrote:
> On Fri, May 23, 2025 at 02:10:46PM +0200, Arnd Bergmann wrote:
...
> > + depends on INTEL_PLATFORM_DEVICES || !(X86 && ACPI)
>
> ^
> Did you mean X86_PLATFORM_DEVICES here?
Why do we need to depend on the whole thingy (yes, it will be enabled at the
end) if we only talking about Intel?
> With that, Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> I see several drivers selecting
> X86_PLATFORM_DEVICES though. Maybe they should also be translated to
> dependencies instead?
I think so, selecting that sounds wrong.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-28 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 12:10 [PATCH] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency Arnd Bergmann
2025-05-27 20:55 ` Lucas De Marchi
2025-05-28 9:34 ` Andy Shevchenko [this message]
2025-05-28 10:03 ` Arnd Bergmann
2025-05-28 10:16 ` Andy Shevchenko
2025-05-28 10:17 ` Christopher Snowhill
2025-05-28 10:31 ` Andy Shevchenko
2025-05-28 11:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDbYs7QZRfr2i80A@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=himal.prasad.ghimiray@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox