Re: [PATCH] staging: rtl8723bs: fix checkpatch issues in rtw_pwrctrl.c

Dan Carpenter
2025-05-28T10:08:46Z

On Wed, May 28, 2025 at 05:19:14PM +0800, Shawn Hua wrote:
> This patch addresses several style issues in rtw_pwrctrl.c, as reported by checkpat
> ch.pl. I’ve fixed most warnings and errors, but left CamelCase and one type of CHECK unresolved.
>
> I’m new to kernel development and submitting this for learning purposes. Please let me know if this type of patch is still helpful, or if it should be reworked or dropped.

Emails and patches should line wrap at 74 characters.

>
> Best regards,
> Shawn Hua
> -----

Don't start your patch with an email, we don't want that in the git log.

> This patch fixes ~80 checkpatch.pl style issues, including spacing, indentation, and alignment.
>
> Remaining issues:
> - CamelCase warnings were left unchanged to avoid breaking interface consistency across related files.
> - One CHECK regarding alignment with open parenthesis could not be resolved despite several attempts.

Don't list the things you haven't done.

>
> No functional changes were made.
>

This does too many things at once. Also start with the latest code.
Some of these are already fixed.

regards,
dan carpenter