From: Dan Carpenter <dan.carpenter@linaro.org>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Shiju Jose <shiju.jose@huawei.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Li Ming <ming.li@zohomail.com>, Fan Ni <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] cxl: fix return value in cxlctl_validate_set_features()
Date: Wed, 28 May 2025 19:15:36 +0300 [thread overview]
Message-ID: <aDc2qGgYVzXMSUpz@stanley.mountain> (raw)
In-Reply-To: <aDcqO5hlGrRXzIPT@aschofie-mobl2.lan>
On Wed, May 28, 2025 at 08:22:35AM -0700, Alison Schofield wrote:
> On Wed, May 28, 2025 at 11:11:41AM +0300, Dan Carpenter wrote:
> > The cxlctl_validate_set_features() function is type bool. It's supposed
> > to return true for valid requests and false for invalid. However, this
> > error path returns ERR_PTR(-EINVAL) which is true when it was intended to
> > return false.
>
> Shiju - Can you trace this one through and add the impact statement?
> Wondering if this is going to fail gracefully, or badly, further
> down this path?
>
Sorry, I would normally analyse this a bit more myself, but it's only in
linux-next so I assumed no one was using it yet. It ends up being fine.
cxlctl_set_feature() has a check for:
if (rpc_in->op_size <= sizeof(feat_in->hdr))
at the start and sizeof(feat_in->hdr) is larger than sizeof(uuid_t).
regards,
dan carpenter
next prev parent reply other threads:[~2025-05-28 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 8:11 [PATCH next] cxl: fix return value in cxlctl_validate_set_features() Dan Carpenter
2025-05-28 15:22 ` Alison Schofield
2025-05-28 16:15 ` Dan Carpenter [this message]
2025-05-28 16:21 ` Shiju Jose
2025-06-09 16:14 ` Ira Weiny
2025-06-09 16:39 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDc2qGgYVzXMSUpz@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox