From: Vishal Chourasia <vishalc@linux.ibm.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: cgroup: clarify controller enabling semantics
Date: Wed, 28 May 2025 18:48:37 +0530 [thread overview]
Message-ID: <aDcNLTA2JfoLXdIM@linux.ibm.com> (raw)
In-Reply-To: <vzdrzqphpjnvrfynx7ajdrgfraavebig4edipde3kulxp2euqh@7p32zx7ql6k6>
On Tue, May 27, 2025 at 11:58:50AM +0200, Michal Koutný wrote:
> Hello.
>
> On Tue, May 27, 2025 at 02:23:36PM +0530, Vishal Chourasia <vishalc@linux.ibm.com> wrote:
> > --- a/Documentation/admin-guide/cgroup-v2.rst
> > +++ b/Documentation/admin-guide/cgroup-v2.rst
> > @@ -438,8 +438,8 @@ Controlling Controllers
> > Enabling and Disabling
> > ~~~~~~~~~~~~~~~~~~~~~~
> >
> > -Each cgroup has a "cgroup.controllers" file which lists all
> > -controllers available for the cgroup to enable::
> > +Each cgroup has a cgroup.controllers file, which lists all the controllers
> > +available for that cgroup and which can be enabled for its children.
> >
> > # cat cgroup.controllers
> > cpu io memory
>
> Honestly, I see little difference between the two resulting formulations.
> Could you perhaps add an example where the documentation confused you or
> behavior was not what you expected based on the docs?
Hello Michal,
The part that was confused me, was the meaning behind controller being
available vs. enabled in a cgroup.
Though, the documentation does mention what it means for a controller to
be enabled in a cgroup later in the text. But at the point of the
change it is unclear.
Thanks
Vishal
>
> Thanks,
> Michal
next prev parent reply other threads:[~2025-05-28 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 8:53 [PATCH] Documentation: cgroup: clarify controller enabling semantics Vishal Chourasia
2025-05-27 9:58 ` Michal Koutný
2025-05-28 13:18 ` Vishal Chourasia [this message]
2025-05-28 17:05 ` Michal Koutný
2025-05-28 18:08 ` Vishal Chourasia
2025-05-28 13:31 ` Vishal Chourasia
2025-05-27 10:04 ` Bagas Sanjaya
2025-05-28 17:28 ` Vishal Chourasia
2025-05-28 15:23 ` Waiman Long
2025-05-28 15:45 ` Waiman Long
2025-05-28 17:37 ` Vishal Chourasia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDcNLTA2JfoLXdIM@linux.ibm.com \
--to=vishalc@linux.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).