From: Danilo Krummrich <dakr@kernel.org>
To: Remo Senekowitsch <remo@buenzli.dev>
Cc: "Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v7 0/9] More Rust bindings for device property reads
Date: Fri, 30 May 2025 21:56:35 +0200 [thread overview]
Message-ID: <aDoNczwEWCDows_-@pollux> (raw)
In-Reply-To: <20250530192856.1177011-1-remo@buenzli.dev>
On Fri, May 30, 2025 at 09:28:47PM +0200, Remo Senekowitsch wrote:
> changes in v7:
> * Fix a typo in a commit message.
> * Fix bug in `FwNode::display_path`. I took a slightly different
> approach than the one suggested, using `Either` to handle the
> owned and borrowed case. That also removes the conditional
> `fwnode_handle_put` at the end.
That's a good idea, but also a bit unfortunate; there are efforts to remove
Either [1] in favor of using - more descriptive - custom enum types.
Can you please replace this with e.g. an enum Node with a Borrowed and Owned
variant?
[1] https://lore.kernel.org/lkml/20250519124304.79237-1-lossin@kernel.org/
next prev parent reply other threads:[~2025-05-30 19:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 19:28 [PATCH v7 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 1/9] rust: device: Create FwNode abstraction for accessing device properties Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 2/9] rust: device: Enable accessing the FwNode of a Device Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 3/9] rust: device: Add property_present() to FwNode Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 4/9] rust: device: Enable printing fwnode name and path Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 5/9] rust: device: Introduce PropertyGuard Remo Senekowitsch
2025-06-05 15:08 ` Rob Herring
2025-06-05 16:16 ` Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 6/9] rust: device: Implement accessors for firmware properties Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 7/9] rust: device: Add child accessor and iterator Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 8/9] rust: device: Add property_get_reference_args Remo Senekowitsch
2025-05-30 19:28 ` [PATCH v7 9/9] samples: rust: platform: Add property read examples Remo Senekowitsch
2025-05-30 19:56 ` Danilo Krummrich [this message]
2025-05-30 21:45 ` [PATCH v7 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-30 21:50 ` Danilo Krummrich
2025-06-05 15:21 ` Rob Herring
2025-06-03 5:10 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDoNczwEWCDows_-@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=remo@buenzli.dev \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).