From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 422AE223DC1; Wed, 4 Jun 2025 10:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749032651; cv=none; b=pvnmswse2M1kZNwxNZ1l+0cGkIZ9klUWb7iQW8W9CtbHSAhPXB4cQTNU+fSHJ5zkeflgjtMUwOir/jUMNfrousw48KJoxOHi1LHZHm+kBpUyg2Dd4NG040eZG8Z9fLRbUgvDHH+orSWtpkOLnoS93mvVOCqkH8W8eH3LxmB5NFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749032651; c=relaxed/simple; bh=CkA7t5JHKnLC81OTeJgx+nWLwzFbh3oMj2svLeegIBI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AXMGN6YcX0Gd1M+JYwMhLiy/E7FrqHEgT2QDmTEorle3RzRIoJYV2o3iNXnSWHKoMA8sa514hmYTg4RR/pKTNEGUnbegNKsIg7AAXH0GznnTQtaeHTwgjaAWrAK8EvKA5TmDtcIeylqRm+UFDgrhneRogs8UkGbBkw+tpjiVIz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uSV2UJw/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uSV2UJw/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6737C4CEE7; Wed, 4 Jun 2025 10:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749032650; bh=CkA7t5JHKnLC81OTeJgx+nWLwzFbh3oMj2svLeegIBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uSV2UJw/i73iytoNxBk5Iq4aWiF3a/acB6XUW19B7KG1PXEN5f6k5B2Ze3TM0qCDo 4VDjEqfa30L+LZx9eKuMQ7l1S61c9UDyfF6+jDaATvRlem3OHYhVNwWfFKOpGO1rYk T/ddZxpTCRY2C1NI5YwvkfVom5CPEBCjXNMoRqcTHtTs9zfgMQ9LQug8BJ7mNF9pm8 mWUsU24tydD9GKZb4+5cD4y208fFnLyOnqObAK3XPzSgMB3Mm1boem0vcxnZONCRc7 43nKuL9JjINnDmWe2KF79z1QsNZXYLy6SV2qdxPxWloUtUPwvACeDhsQYxmjnDEzqm e6jHQ/4+4wcuQ== Date: Wed, 4 Jun 2025 12:24:03 +0200 From: Danilo Krummrich To: Alexandre Courbot Cc: Lyude Paul , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , John Hubbard , Ben Skeggs , Joel Fernandes , Timur Tabi , Alistair Popple , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 17/20] gpu: nova-core: compute layout of the FRTS region Message-ID: References: <20250521-nova-frts-v4-0-05dfd4f39479@nvidia.com> <20250521-nova-frts-v4-17-05dfd4f39479@nvidia.com> <632966ba8231e8f3c20350b217b225301280cdd3.camel@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 04, 2025 at 01:18:37PM +0900, Alexandre Courbot wrote: > On Wed Jun 4, 2025 at 6:14 AM JST, Lyude Paul wrote: > > On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote: > >> + const NV_PRAMIN_SIZE: u64 = 0x100000; > > > > Don't leave those size constants out, they're getting lonely :C > > Not quite sure where I should put these; they are not used (for now) > anywhere else, so the relevant scope is not obvious to me. Any > suggestion? I assume Lyude means that you should use SZ_1M here. :)