[v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[Meng Li]

v4:
 - Improve commit log of patch0002

v3:
 - merge patch 0002 into patch 0001
 - improve the commit log of patches

v2:
 - improve the commit log of patch 0001
 - add another 2 patches to fix below warning
 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000(fsl,imx21-wdt): big-endian: False schema does not allow True

v1:
 - create patch 0001-arch-arm64-dts-add-big-endian-property-back-into-wat.patch

Meng Li (2):
  dt-bindings: watchdog: fsl-imx-wdt: add compatible string
    fsl,ls1046a-wdt
  arch: arm64: dts: add big-endian property back into watchdog node

 Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi              | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.34.1

[v4 PATCH 1/2] dt-bindings: watchdog: fsl-imx-wdt: add compatible string fsl,ls1046a-wdt

[Meng Li]

Add compatible string fsl,ls1046a-wdt for ls1046a SoC. fsl,ls1046a-wdt
allows big-endian property.

Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 8a6c3a75a547..34951783a633 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -37,6 +37,7 @@ properties:
               - fsl,ls1012a-wdt
               - fsl,ls1021a-wdt
               - fsl,ls1043a-wdt
+              - fsl,ls1046a-wdt
               - fsl,vf610-wdt
           - const: fsl,imx21-wdt
 
@@ -105,6 +106,7 @@ allOf:
                 - fsl,ls1012a-wdt
                 - fsl,ls1021a-wdt
                 - fsl,ls1043a-wdt
+                - fsl,ls1046a-wdt
     then:
       properties:
         big-endian: false
-- 
2.34.1

[v4 PATCH 2/2] arch: arm64: dts: add big-endian property back into watchdog node

[Meng Li]

Watchdog doesn't work on NXP ls1046ardb board because in commit
7c8ffc5555cb("arm64: dts: layerscape: remove big-endian for mmc nodes"),
it intended to remove the big-endian from mmc node, but the big-endian of
watchdog node is also removed by accident. So, add watchdog big-endian
property back.

In addition, add compatible string fsl,ls1046a-wdt, which allow big-endian
property.

Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for mmc nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 0baf256b4400..983b2f0e8797 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -687,11 +687,12 @@ lpuart5: serial@29a0000 {
 		};
 
 		wdog0: watchdog@2ad0000 {
-			compatible = "fsl,imx21-wdt";
+			compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
 			reg = <0x0 0x2ad0000 0x0 0x10000>;
 			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
 					    QORIQ_CLK_PLL_DIV(2)>;
+			big-endian;
 		};
 
 		edma0: dma-controller@2c00000 {
-- 
2.34.1

Re: [v4 PATCH 1/2] dt-bindings: watchdog: fsl-imx-wdt: add compatible string fsl,ls1046a-wdt

[Rob Herring]

On Wed, Jun 04, 2025 at 11:42:45AM +0800, Meng Li wrote:
> Add compatible string fsl,ls1046a-wdt for ls1046a SoC. fsl,ls1046a-wdt
> allows big-endian property.
> 
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
>  1 file changed, 2 insertions(+)

You missed Cc'ing the watchdog maintainer if you want this applied.

Acked-by: Rob Herring (Arm) <robh@kernel.org>

RE: [v4 PATCH 1/2] dt-bindings: watchdog: fsl-imx-wdt: add compatible string fsl,ls1046a-wdt

[Li, Meng]

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, June 6, 2025 1:41 AM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: linux@roeck-us.net; s.hauer@pengutronix.de; kernel@pengutronix.de;
> linux-watchdog@vger.kernel.org; imx@lists.linux.dev; shawnguo@kernel.org;
> conor+dt@kernel.org; Frank.Li@nxp.com; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [v4 PATCH 1/2] dt-bindings: watchdog: fsl-imx-wdt: add
> compatible string fsl,ls1046a-wdt
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Wed, Jun 04, 2025 at 11:42:45AM +0800, Meng Li wrote:
> > Add compatible string fsl,ls1046a-wdt for ls1046a SoC. fsl,ls1046a-wdt
> > allows big-endian property.
> >
> > Signed-off-by: Meng Li <Meng.Li@windriver.com>
> > ---
> >  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> You missed Cc'ing the watchdog maintainer if you want this applied.
> 

Thanks for reminding me.
I will add maintainer in v4 review

Regards,
LImeng

> Acked-by: Rob Herring (Arm) <robh@kernel.org>

RE: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[Li, Meng]

Add watchdog binding maintainer for the patch-0001.

Thanks,
Limeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Wednesday, June 4, 2025 11:43 AM
> To: linux@roeck-us.net; s.hauer@pengutronix.de; kernel@pengutronix.de;
> linux-watchdog@vger.kernel.org; imx@lists.linux.dev; shawnguo@kernel.org;
> robh@kernel.org; conor+dt@kernel.org; Frank.Li@nxp.com
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Li, Meng <Meng.Li@windriver.com>
> Subject: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog
> feature
> 
> v4:
>  - Improve commit log of patch0002
> 
> v3:
>  - merge patch 0002 into patch 0001
>  - improve the commit log of patches
> 
> v2:
>  - improve the commit log of patch 0001
>  - add another 2 patches to fix below warning
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb:
> watchdog@2ad0000(fsl,imx21-wdt): big-endian: False schema does not allow
> True
> 
> v1:
>  - create patch 0001-arch-arm64-dts-add-big-endian-property-back-into-
> wat.patch
> 
> Meng Li (2):
>   dt-bindings: watchdog: fsl-imx-wdt: add compatible string
>     fsl,ls1046a-wdt
>   arch: arm64: dts: add big-endian property back into watchdog node
> 
>  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi              | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> --
> 2.34.1

RE: [v4 PATCH 1/2] dt-bindings: watchdog: fsl-imx-wdt: add compatible string fsl,ls1046a-wdt

[Li, Meng]

Add watchdog binding maintainer.

Thanks,
Limeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Wednesday, June 4, 2025 11:43 AM
> To: linux@roeck-us.net; s.hauer@pengutronix.de; kernel@pengutronix.de;
> linux-watchdog@vger.kernel.org; imx@lists.linux.dev; shawnguo@kernel.org;
> robh@kernel.org; conor+dt@kernel.org; Frank.Li@nxp.com
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Li, Meng <Meng.Li@windriver.com>
> Subject: [v4 PATCH 1/2] dt-bindings: watchdog: fsl-imx-wdt: add compatible
> string fsl,ls1046a-wdt
> 
> Add compatible string fsl,ls1046a-wdt for ls1046a SoC. fsl,ls1046a-wdt allows
> big-endian property.
> 
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 8a6c3a75a547..34951783a633 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -37,6 +37,7 @@ properties:
>                - fsl,ls1012a-wdt
>                - fsl,ls1021a-wdt
>                - fsl,ls1043a-wdt
> +              - fsl,ls1046a-wdt
>                - fsl,vf610-wdt
>            - const: fsl,imx21-wdt
> 
> @@ -105,6 +106,7 @@ allOf:
>                  - fsl,ls1012a-wdt
>                  - fsl,ls1021a-wdt
>                  - fsl,ls1043a-wdt
> +                - fsl,ls1046a-wdt
>      then:
>        properties:
>          big-endian: false
> --
> 2.34.1

Re: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[Frank Li]

On Fri, Jun 06, 2025 at 01:46:56AM +0000, Li, Meng wrote:
> Add watchdog binding maintainer for the patch-0001.

You may need resend whole patches, which included linux-watchdog, they may
use patchwork to track patches and miss this one.

Frank

>
> Thanks,
> Limeng
>
> > -----Original Message-----
> > From: Li, Meng <Meng.Li@windriver.com>
> > Sent: Wednesday, June 4, 2025 11:43 AM
> > To: linux@roeck-us.net; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > linux-watchdog@vger.kernel.org; imx@lists.linux.dev; shawnguo@kernel.org;
> > robh@kernel.org; conor+dt@kernel.org; Frank.Li@nxp.com
> > Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Li, Meng <Meng.Li@windriver.com>
> > Subject: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog
> > feature
> >
> > v4:
> >  - Improve commit log of patch0002
> >
> > v3:
> >  - merge patch 0002 into patch 0001
> >  - improve the commit log of patches
> >
> > v2:
> >  - improve the commit log of patch 0001
> >  - add another 2 patches to fix below warning
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb:
> > watchdog@2ad0000(fsl,imx21-wdt): big-endian: False schema does not allow
> > True
> >
> > v1:
> >  - create patch 0001-arch-arm64-dts-add-big-endian-property-back-into-
> > wat.patch
> >
> > Meng Li (2):
> >   dt-bindings: watchdog: fsl-imx-wdt: add compatible string
> >     fsl,ls1046a-wdt
> >   arch: arm64: dts: add big-endian property back into watchdog node
> >
> >  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi              | 3 ++-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > --
> > 2.34.1
>

[v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[Meng Li]

v4:
 - Improve commit log of patch0002

v3:
 - merge patch 0002 into patch 0001
 - improve the commit log of patches

v2:
 - improve the commit log of patch 0001
 - add another 2 patches to fix below warning
 arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000(fsl,imx21-wdt): big-endian: False schema does not allow True

v1:
 - create patch 0001-arch-arm64-dts-add-big-endian-property-back-into-wat.patch

Meng Li (2):
  dt-bindings: watchdog: fsl-imx-wdt: add compatible string
    fsl,ls1046a-wdt
  arch: arm64: dts: add big-endian property back into watchdog node

 Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi              | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.34.1

RE: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[Li, Meng]

> -----Original Message-----
> From: Frank Li <Frank.li@nxp.com>
> Sent: Friday, June 6, 2025 11:34 PM
> To: Li, Meng <Meng.Li@windriver.com>
> Cc: linux@roeck-us.net; s.hauer@pengutronix.de; kernel@pengutronix.de;
> linux-watchdog@vger.kernel.org; imx@lists.linux.dev; shawnguo@kernel.org;
> robh@kernel.org; conor+dt@kernel.org; krzk+dt@kernel.org; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [v4 PATCH 0/2] create patches for nxp-ls1046a platform
> watchdog feature
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Fri, Jun 06, 2025 at 01:46:56AM +0000, Li, Meng wrote:
> > Add watchdog binding maintainer for the patch-0001.
> 
> You may need resend whole patches, which included linux-watchdog, they
> may use patchwork to track patches and miss this one.
> 

Thanks for reminding me.
I have sent the whole patches.

Regards,
Limeng

> Frank
> 
> >
> > Thanks,
> > Limeng
> >
> > > -----Original Message-----
> > > From: Li, Meng <Meng.Li@windriver.com>
> > > Sent: Wednesday, June 4, 2025 11:43 AM
> > > To: linux@roeck-us.net; s.hauer@pengutronix.de;
> > > kernel@pengutronix.de; linux-watchdog@vger.kernel.org;
> > > imx@lists.linux.dev; shawnguo@kernel.org; robh@kernel.org;
> > > conor+dt@kernel.org; Frank.Li@nxp.com
> > > Cc: linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; Li, Meng
> > > <Meng.Li@windriver.com>
> > > Subject: [v4 PATCH 0/2] create patches for nxp-ls1046a platform
> > > watchdog feature
> > >
> > > v4:
> > >  - Improve commit log of patch0002
> > >
> > > v3:
> > >  - merge patch 0002 into patch 0001
> > >  - improve the commit log of patches
> > >
> > > v2:
> > >  - improve the commit log of patch 0001
> > >  - add another 2 patches to fix below warning
> > >  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb:
> > > watchdog@2ad0000(fsl,imx21-wdt): big-endian: False schema does not
> > > allow True
> > >
> > > v1:
> > >  - create patch
> > > 0001-arch-arm64-dts-add-big-endian-property-back-into-
> > > wat.patch
> > >
> > > Meng Li (2):
> > >   dt-bindings: watchdog: fsl-imx-wdt: add compatible string
> > >     fsl,ls1046a-wdt
> > >   arch: arm64: dts: add big-endian property back into watchdog node
> > >
> > >  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
> > >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi              | 3 ++-
> > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > >
> > > --
> > > 2.34.1
> >

RE: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog feature

[Li, Meng]

I had resent the whole patch and include all the maintainers
More than ten days have passed, but there is no any progress and reply in upstream.
Is there any comment on these patches, do I need to improve these patches?

Thanks,
LImeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Sunday, June 8, 2025 11:06 AM
> To: krzk+dt@kernel.org; linux@roeck-us.net; s.hauer@pengutronix.de;
> kernel@pengutronix.de; linux-watchdog@vger.kernel.org; imx@lists.linux.dev;
> shawnguo@kernel.org; robh@kernel.org; conor+dt@kernel.org;
> Frank.Li@nxp.com
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Li, Meng <Meng.Li@windriver.com>
> Subject: [v4 PATCH 0/2] create patches for nxp-ls1046a platform watchdog
> feature
> 
> v4:
>  - Improve commit log of patch0002
> 
> v3:
>  - merge patch 0002 into patch 0001
>  - improve the commit log of patches
> 
> v2:
>  - improve the commit log of patch 0001
>  - add another 2 patches to fix below warning
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb:
> watchdog@2ad0000(fsl,imx21-wdt): big-endian: False schema does not allow
> True
> 
> v1:
>  - create patch 0001-arch-arm64-dts-add-big-endian-property-back-into-
> wat.patch
> 
> Meng Li (2):
>   dt-bindings: watchdog: fsl-imx-wdt: add compatible string
>     fsl,ls1046a-wdt
>   arch: arm64: dts: add big-endian property back into watchdog node
> 
>  Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi              | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> --
> 2.34.1