Re: [PATCH 1/1 v6.16] perf test event_uniquifying: Skip test on platforms without 'clockticks' events

[Namhyung Kim <namhyung@kernel.org>]

On Thu, Jun 05, 2025 at 04:22:40PM -0300, Arnaldo Carvalho de Melo wrote:
> I'll add this to perf-tools for v6.16, please check.
 
Plesae see

https://lore.kernel.org/linux-perf-users/20250521224513.1104129-1-ctshao@google.com/

Thanks,
Namhyung

> ---
> 
> This test assumes the 'clockticks' event is generally available, which
> isn't the case, for instance, on AMD systems such as:
> 
>   root@number:~# grep -m1 "model name" /proc/cpuinfo
>   model name	: AMD Ryzen 9 9950X3D 16-Core Processor
>   root@number:~# perf list clockticks
> 
>   List of pre-defined events (to be used in -e or -M):
> 
>   root@number:~#
> 
> So skip this test when 'clockticks' isn't available.
> 
> This should be improved to find other events that are available in
> multiple PMUs so that the intent of the test is achieved in more
> platforms.
> 
> Fixes: cb422594d62066a5 ("perf test: Add stat uniquifying test")
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Chun-Tse Shao <ctshao@google.com>
> Cc: Dr. David Alan Gilbert <linux@treblig.org>
> Cc: Howard Chu <howardchu95@gmail.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: James Clark <james.clark@linaro.org>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Levi Yun <yeoreum.yun@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Weilin Wang <weilin.wang@intel.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/tests/shell/stat+event_uniquifying.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/stat+event_uniquifying.sh b/tools/perf/tests/shell/stat+event_uniquifying.sh
> index 5ec35c52b7d9651e..20498b6eadb57702 100755
> --- a/tools/perf/tests/shell/stat+event_uniquifying.sh
> +++ b/tools/perf/tests/shell/stat+event_uniquifying.sh
> @@ -49,6 +49,12 @@ test_event_uniquifying() {
>      uniquified_event_array+=("${uniquified_event}")
>    done < <(${perf_tool} list -v ${event} | grep "\[Kernel PMU event\]")
>  
> +  if [ ${#uniquified_event_array[@]} -eq 0 ]; then
> +    echo "'clocktick' event not available on this machine"
> +    err=2
> +    return
> +  fi
> +
>    perf_command="${perf_tool} stat -e $event -A -o ${stat_output} -- true"
>    $perf_command
>  
> -- 
> 2.49.0
>