From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6651B38385 for ; Mon, 9 Jun 2025 14:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749479996; cv=none; b=YrbRYx1Hn2aOzhMVjTVYDy8ilC8Yal+c/FeoJdNLNo/DO06S6pHamdbzQG6fad6cJt94Qup/s0skgrS4NFaVygZDIdca15xQtE6KlR8j4/c0ATD2YbTQSho95YFeNVgfSi2jVm9HpGvyjIGPqZGNHPTLicfYH85P/gExBF04aGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749479996; c=relaxed/simple; bh=Tpmkew92d3UkCD/uBMzxFAJa947kpytzKjgdSyXBJfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cpf6gfPgJL2AX+i7Mb7ORQJBaNew+7m5bA175TzQYj2m2kGmiBz82w/52wLlx62akAR9frdBGsuYeSJspwTaUI0flYTOXGqfUVTXETseTVTnN23dRjZIY1Whbi3IOAICIp+XetCFF1Vz5SUW7Vt4KFpKW5q1LGadnVYt2zSQ6ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Kdpcp82k; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Kdpcp82k" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a365a6804eso2739473f8f.3 for ; Mon, 09 Jun 2025 07:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749479992; x=1750084792; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TBUyMfCvEgObXbMHMtHUW0hbnDDnIuTip1OX215Qd8E=; b=Kdpcp82kCwc92L/UgF0Whbbj5VvCOwVSJhAJI/QudBtP5S2cjq4ObAHOiP1czxYYYn O6iPWkkHhrJExJTcxZPbngPEKUi2VMjyt/51lVF+pTF41ui+xB0Aj5eoYC1oQ27uNOBq BuEjyEHMzbuiJ31XKAbPjDhpACLoXtJu2aYxm5KTEmyWjpDt/S0bFnCoA3RvCp1e89/L djALovjdfi6jGY5TQm3cGS4IEhNrd8XjMd4xnTGHuzA7WAZCP00TWNIl4lAmLQxF2l2J VkNvl7s3SKVDH8uaN6YZO5y8ZPEjs77AGw7uL9hM6BukTjwSS4gWXQRvpkbtpZ3VmVsp MIkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749479992; x=1750084792; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TBUyMfCvEgObXbMHMtHUW0hbnDDnIuTip1OX215Qd8E=; b=eDhtKpArzqXl3IEoILXhOkhtoREvAVnIaqWv+WPJExvElPSK8mvE4y6/KWGUGSpuT3 ZGNirBnVDRDO8c9qUEZlQH3aE5h/swUhByOQr06YaqIPd6FXTg+gMzN0x8joKlnz+CFw Rqy192WH5lZAFl8iv82fCAFXtSY9ITaegF2/wqIar7xDGA86R/myhjnV5Z80xBzMmJwv jAn/VZ6XAIncpNKOKOhI9fILLO8J9xuVuX27fXlOHtDxtyDnXUxGNoGKC26Muz7741+7 1m5N9qIO1wok07O8X6wx3XdB2fz7ZZ6XKABisVvxxl97PKXUCfpnR/S/QfuOU8sgKoyY uBvA== X-Forwarded-Encrypted: i=1; AJvYcCU/qI+kVLpM0fsPNU8/oMe//RcLEuTUSB1YTNUhC+QRg/nThZPnbTh8FpGxktq9WQYwagiqLyqzlju2wwc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/zKXgloOh/FQw/3d+yk9ZtqypFgerhHGdzxWRuCo6ToBIISEK oySWrifNkmteJrl2VO+IlAsp42kY+ETVzBIS7ugdTxfn27xF19D30uVcIUm5fYUwAlM= X-Gm-Gg: ASbGncvyLPu5Y7aPpNrAYMOKggnQuO9rWAS5XPww+fhqwUpCF5SYBIFEXouWa33+rmJ aAeM+/6VHCwwAXn0eCKwyip2qxz09i8EA8ZemgxXQWUYVXRyAJvzYeutN35sjQMfiH1LfYnrGeD RrXNlagNyqBzGhTSdWPZ7tePdbIAbz+ajhkJJL78tMAtB5vHAo9ZcgcOOzT0Ze/J9FgJPOpeYUh nYOTwR7AWeDUHNyCH6xWhpSZOvKPWXtIThqtxgLP4/1iOTkii1hyL5oFwHgMVGb/HuWo7NTrPkd u4btuvwJ0wNYmSM41FZrszCaUYvsdk4Og/TuYBaaosVzv1jzbkxf2welCyDn0kBA X-Google-Smtp-Source: AGHT+IHQ9WnlIb2N+Qu2oqWlSl1QrWztkyTzn0RfuZ+Bgd3cAwyVXJ521y5E6cUICXCtVhbSAJCdMQ== X-Received: by 2002:a5d:5846:0:b0:3a5:2b75:56b3 with SMTP id ffacd0b85a97d-3a531cae8d7mr10675904f8f.24.1749479991728; Mon, 09 Jun 2025 07:39:51 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603092635sm55068605ad.81.2025.06.09.07.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 07:39:50 -0700 (PDT) Date: Mon, 9 Jun 2025 16:39:25 +0200 From: Petr Mladek To: Kees Cook Cc: Sergio Perez Gonzalez , Vlastimil Babka , David Rientjes , Bagas Sanjaya , Jonathan Corbet , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Harry Yoo , "Paul E. McKenney" , Randy Dunlap , Tamir Duberstein , Miguel Ojeda , Alice Ryhl , linux-doc@vger.kernel.org, linux-mm@kvack.org, Thomas Huth , "Borislav Petkov (AMD)" , Ard Biesheuvel , Greg Kroah-Hartman , Andreas Hindborg , Stephen Boyd , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] slab: Decouple slab_debug and no_hash_pointers Message-ID: References: <20250415170232.it.467-kees@kernel.org> <202506051314.D6EDFA91D@keescook> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202506051314.D6EDFA91D@keescook> On Thu 2025-06-05 13:15:32, Kees Cook wrote: > On Wed, Apr 16, 2025 at 02:06:21PM +0200, Petr Mladek wrote: > > On Tue 2025-04-15 10:02:33, Kees Cook wrote: > > > Some system owners use slab_debug=FPZ (or similar) as a hardening option, > > > but do not want to be forced into having kernel addresses exposed due > > > to the implicit "no_hash_pointers" boot param setting.[1] > > > > > > Introduce the "hash_pointers" boot param, which defaults to "auto" > > > (the current behavior), but also includes "always" (forcing on hashing > > > even when "slab_debug=..." is defined), and "never". The existing > > > "no_hash_pointers" boot param becomes an alias for "hash_pointers=never". > > > > > > This makes it possible to boot with "slab_debug=FPZ hash_pointers=always". > > > > > > Link: https://github.com/KSPP/linux/issues/368 [1] > > > Fixes: 792702911f58 ("slub: force on no_hash_pointers when slub_debug is enabled") > > > Co-developed-by: Sergio Perez Gonzalez > > > Signed-off-by: Sergio Perez Gonzalez > > > Acked-by: Vlastimil Babka > > > Acked-by: David Rientjes > > > Reviewed-by: Bagas Sanjaya > > > Signed-off-by: Kees Cook > > > > Tested-by: Petr Mladek > > Reviewed-by: Petr Mladek > > > > I am going to wait few more days for a potential feedback. > > I'll queue it for 6.16 unless anyone complains. > > Hi, > > Is this still planned for 6.16? I just noticed it wasn't in -next, and > we're almost to the end of the merge window... I am terribly sorry. I have forgot this patch... I have just pushed it into printk/linux.git, branch for-6.17-hash_pointers. Also I updated the documentation, aka applied the diff from https://lore.kernel.org/r/202504181307.254F81843@keescook See https://web.git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git/commit/?h=for-6.17-hash_pointers&id=de1c831a7898f164c1c2703c6b2b9e4fb4bebefc As the branch name suggests, I am going to push it for 6.17. If it is too late for you then please let me know. Best Regards, Petr