public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes
Date: Tue, 10 Jun 2025 09:39:05 +0000	[thread overview]
Message-ID: <aEf9OfSWjp7id68A@kekkonen.localdomain> (raw)
In-Reply-To: <55fd5868-0481-42e1-b56b-80f59d724364@foss.st.com>

Hi Benjamin,

On Tue, Jun 10, 2025 at 11:31:05AM +0200, Benjamin Mugnier wrote:
> Hi Sakari,
> 
> Thank you for your review.
> 
> On 6/10/25 11:00, Sakari Ailus wrote:
> > Hi Benjamin,
> > 
> > Thanks for the set.
> > 
> > On Mon, Jun 09, 2025 at 03:46:20PM +0200, Benjamin Mugnier wrote:
> >> This series provides small fixes and style improvements to the vd55g1
> >> driver.
> >> Nothing fancy really, just to keep everything up to date.
> > 
> > On all (or at least more than one) patches:
> > 
> > - please add a proper commit message beyond the subject line and
> > 
> > - properly wrap the commit paragraphs (up to 75 characters per line, e.g.
> >   the above paragraph would fit on two lines).
> > 
> 
> Yes, commit descriptions have been added in v2. Media-ci rightfully
> yelled at me for that ;)
> 
> I don't see any commit paragraphs being above 75 characters, my vim
> seems to be properly configured.

It's not over 75 characters per line but some lines are shorter than they
could be.

> Do you mean the commit header too perhaps ? For example "media: i2c:
> vd55g1: Miscellaneous fixes".

-- 
Regards,

Sakari Ailus

      reply	other threads:[~2025-06-10  9:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 13:46 [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 1/4] media: i2c: vd55g1: Fix RATE macros not being expressed in bps Benjamin Mugnier
2025-06-10  9:01   ` Sakari Ailus
2025-06-10  9:31     ` Benjamin Mugnier
2025-06-12  6:24       ` Sakari Ailus
2025-06-12 14:35         ` Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 2/4] media: i2c: vd55g1: Fix return code in vd55g1_enable_streams error path Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 3/4] media: i2c: vd55g1: Setup sensor external clock before patching Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 4/4] media: i2c: vd55g1: Use first index of mbus codes array as default Benjamin Mugnier
2025-06-10  9:04   ` Sakari Ailus
2025-06-10  9:31     ` Benjamin Mugnier
2025-06-10  9:41       ` Sakari Ailus
2025-06-10  9:00 ` [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes Sakari Ailus
2025-06-10  9:31   ` Benjamin Mugnier
2025-06-10  9:39     ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEf9OfSWjp7id68A@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox