Re: [PATCH v3 1/2] platform/x86: Move Lenovo files into lenovo subdir

Mark Pearson
2025-06-10T01:22:16Z

Thanks Andy,

On Mon, Jun 9, 2025, at 4:17 PM, Andy Shevchenko wrote:
> On Mon, Jun 09, 2025 at 08:27:24AM -0400, Mark Pearson wrote:
>> Create lenovo subdirectory for holding Lenovo specific drivers.
>
> ...
>
>> LENOVO WMI HOTKEY UTILITIES DRIVER
>> M: Jackie Dong <xy-jackie@139.com>
>> L: platform-driver-x86@vger.kernel.org
>> S: Maintained
>> -F: drivers/platform/x86/lenovo-wmi-hotkey-utilities.c
>> +F: drivers/platform/x86/lenovo/lenovo-wmi-hotkey-utilities.c
>
> Is this correct?
>
Jackie is on my team, he wrote this driver originally (with some help) for one of the thinkbook platforms.
If there are any changes he should review them as he has access to the HW, but I'll be helping too.
I think it's fine - let me know if otherwise.

Just as background: We can't use our Lenovo email addresses for kernel contributions. They're based on an awful Outlook server that is incapable of handling text only emails, and also won't play nice with any other tooling (including git send-email). Not ideal but it is what it is, and I gave up fighting with IT about it (there are some workarounds, but they're arguably worse).

> Otherwise LGTM.
>
Thanks for the review
Mark