Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling

Mark Pearson
2025-06-10T01:27:20Z

Hi Andy

On Mon, Jun 9, 2025, at 4:19 PM, Andy Shevchenko wrote:
> On Mon, Jun 09, 2025 at 08:27:25AM -0400, Mark Pearson wrote:
>> Fix issues reported by kernel test robot.
>> - Require DMI for think-lmi.
>> - Check return from getting serial string
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202506062319.F0IpDxF6-lkp@intel.com/
>
>>
>
> No blank line in tag block.

Oh - I'd not come across that requirement before. I can fix.

>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>
>> - New patch added to series.
>
> Shouldn't it be the first one in the series? It seems to me that this is the
> fix of the original code as well.

I guess. I'll re-order.

>
> ...
>
>> +++ b/drivers/platform/x86/lenovo/think-lmi.c
>
> My understanding is that you need either Kconfig or changing C file.

Does it matter? I figured both were valid. Adding the DMI to the Kconfig makes sure it's used and checking the return code felt sensible.

If you object I'll go with just the Kconfig but I thought the extra check had value and was related to the reported issue so did it as well. Let me know if you feel strongly about it.

Thanks
Mark