Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling

Andy Shevchenko
2025-06-10T13:33:37Z

On Tue, Jun 10, 2025 at 08:28:49AM -0400, Mark Pearson wrote:
> On Tue, Jun 10, 2025, at 3:35 AM, Ilpo Järvinen wrote:
> > On Mon, 9 Jun 2025, Mark Pearson wrote:

...

> >> + serial = dmi_get_system_info(DMI_PRODUCT_SERIAL);
> >> + if (!serial)
> >> + return -EINVAL;
> >
> > This should not return -EINVAL as it is not a problem with the input
> > parameters. Perhaps -ENODEV would make sense instead?
>
> Good point.
> Unless Andy strongly thinks I should drop this bit, I'll fix in the next version

If maintainers are okay to take this approach (both Kconfig and C file
changes), I am fine.

--
With Best Regards,
Andy Shevchenko