From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Waiman Long" <longman@redhat.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Vicentiu Galanopulo" <vicentiu.galanopulo@remote-tech.co.uk>,
"Will Deacon" <will@kernel.org>, "Han Xu" <han.xu@nxp.com>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Yogesh Gaur" <yogeshgaur.83@gmail.com>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
"Andrew Davis" <afd@ti.com>,
linux-kernel@vger.kernel.org,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init()
Date: Wed, 11 Jun 2025 11:33:15 +0300 [thread overview]
Message-ID: <aEk_Sx2qht6WK6yQ@smile.fi.intel.com> (raw)
In-Reply-To: <d8d1ee94-ee95-461f-a5d8-040bb2a1cfee@sirena.org.uk>
On Tue, Jun 10, 2025 at 12:46:12PM +0100, Mark Brown wrote:
> On Tue, Jun 10, 2025 at 12:57:37PM +0300, Andy Shevchenko wrote:
> > On Mon, Jun 09, 2025 at 09:59:46PM +0100, Mark Brown wrote:
>
> > > I don't understand the comment about leaking here? We might end up with
> > > an unitialised mutex but how would we leak anything?
>
> > In case if the mutex_init() allocates something that needs to be freed
> > (in the future).
>
> I don't see how checking the return value impacts that? The management
> via devm is still there either way.
I see now what you mean. Yes, this is more likely applicable to non-devm case.
Thomas, can you adjust the commit message(s), please, for v7?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-11 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 20:38 [PATCH v6 0/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
2025-06-09 20:38 ` [PATCH v6 1/3] spi: spi-nxp-fspi: check return value of devm_mutex_init() Thomas Weißschuh
2025-06-09 20:59 ` Mark Brown
2025-06-10 9:57 ` Andy Shevchenko
2025-06-10 11:46 ` Mark Brown
2025-06-11 8:33 ` Andy Shevchenko [this message]
2025-06-09 20:38 ` [PATCH v6 2/3] leds: lp8860: Check " Thomas Weißschuh
2025-06-09 21:11 ` Andrew Davis
2025-06-09 20:38 ` [PATCH v6 3/3] locking/mutex: Mark devm_mutex_init() as __must_check Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEk_Sx2qht6WK6yQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=afd@ti.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=boqun.feng@gmail.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=vicentiu.galanopulo@remote-tech.co.uk \
--cc=will@kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox