From: Joe Damato <joe@dama.to>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, brett.creeley@amd.com
Subject: Re: [PATCH net-next 1/3] ionic: print firmware heartbeat as unsigned
Date: Thu, 12 Jun 2025 16:31:12 +0300 [thread overview]
Message-ID: <aErWoFty-VDoZ97B@MacBook-Air.local> (raw)
In-Reply-To: <20250609214644.64851-2-shannon.nelson@amd.com>
On Mon, Jun 09, 2025 at 02:46:42PM -0700, Shannon Nelson wrote:
> The firmware heartbeat value is an unsigned number, and seeing
> a negative number when it gets big is a little disconcerting.
> Example:
> ionic 0000:24:00.0: FW heartbeat stalled at -1342169688
>
> Print using the unsigned flag.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2025-06-12 13:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 21:46 [PATCH net-next 0/3] ionic: three little changes Shannon Nelson
2025-06-09 21:46 ` [PATCH net-next 1/3] ionic: print firmware heartbeat as unsigned Shannon Nelson
2025-06-12 13:14 ` Simon Horman
2025-06-12 13:31 ` Joe Damato [this message]
2025-06-09 21:46 ` [PATCH net-next 2/3] ionic: clean dbpage in de-init Shannon Nelson
2025-06-12 13:15 ` Simon Horman
2025-06-12 13:42 ` Joe Damato
2025-06-09 21:46 ` [PATCH net-next 3/3] ionic: cancel delayed work earlier in remove Shannon Nelson
2025-06-12 13:15 ` Simon Horman
2025-06-12 14:01 ` Joe Damato
2025-06-13 9:40 ` [PATCH net-next 0/3] ionic: three little changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aErWoFty-VDoZ97B@MacBook-Air.local \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox