From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C51823E229 for ; Fri, 13 Jun 2025 19:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749843811; cv=none; b=Mw2ojSlfJf7dRM5fsUZ2ggO5fsZZpuQo4o6wbhzzHjmExQvbeR2mQu3HbzNhgthscCucYspIKJvHbuqm12kMLpWPlJsimNfVT2NJLoEYhDnruZDRH4sgmWNOPmhlQBj+k7myvTZQfpBVuWy/9vz1TwqaJu9C5HqHnaNpgqme7Wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749843811; c=relaxed/simple; bh=hC4V+1Dt27/Fv+cHSYNpPlN1jU584vWBlk4E/iSJqNQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ekJzMUs13xNT4YPMmS7YAJebobykvmrLTpYijf2sX2K3owj0+pbgxby5UWmrAs/zzmPTMQAloXBJcvu9vB5v+71H1KjaovUst9Dsw6XtNBs1HTRvc3IMNPu7RqgBNxWhaiiEkkWcgNlS0eK7zOtvgnhvj9naNRUXryiBpNgs7B8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Vd7PKd8w; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Vd7PKd8w" Date: Fri, 13 Jun 2025 12:43:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749843807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RiYXVgcIqh/RTLmK+Rx+QzUVOjDT9BY8SQ3RWUnrRPA=; b=Vd7PKd8wGfZvL5kqVq+Dca3A5hDB3H0EKNSbHMcN6e7P8ORHUnyy6UkFj4MyqfKzaiKyyy cluvv8f1WJyFdH2b+/DBV0z7DYn18aGgYZ50ltz3iGZ+XYjl8KLTJ8+lmr7urH53OmMXpz IzAMWm6MMTUuosIcgGHMBqXqO+4KxIA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sean Christopherson Cc: Marc Zyngier , Paolo Bonzini , Joerg Roedel , David Woodhouse , Lu Baolu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Sairaj Kodilkar , Vasant Hegde , Maxim Levitsky , Joao Martins , Francesco Lavra , David Matlack Subject: Re: [PATCH v3 01/62] KVM: arm64: Explicitly treat routing entry type changes as changes Message-ID: References: <20250611224604.313496-2-seanjc@google.com> <20250611224604.313496-3-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250611224604.313496-3-seanjc@google.com> X-Migadu-Flow: FLOW_OUT On Wed, Jun 11, 2025 at 03:45:04PM -0700, Sean Christopherson wrote: > Explicitly treat type differences as GSI routing changes, as comparing MSI > data between two entries could get a false negative, e.g. if userspace > changed the type but left the type-specific data as- > > Note, the same bug was fixed in x86 by commit bcda70c56f3e ("KVM: x86: > Explicitly treat routing entry type changes as changes"). Yeah, I'll let you guess where I got the idea from... > Fixes: 4bf3693d36af ("KVM: arm64: Unmap vLPIs affected by changes to GSI routing information") > Signed-off-by: Sean Christopherson Reviewed-by: Oliver Upton Thanks, Oliver