From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 400942F1FDF; Fri, 27 Jun 2025 13:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751031848; cv=none; b=TBP4TvcSJrzFy8HtDmmlGuTb1baoswa+YsKlw6njr09Md2wN06+AlccBkhLLsTb2XjS74HPxYa3K9scdzH9lOzQN5pbW+9K9tIJeHsUVTaYE1oaM0rowJ3tP/EXVoWkqrFXkJTE9vrLVzx8NZNmUunQspOQHXce30Gmc892Zl84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751031848; c=relaxed/simple; bh=sKa5RTfY3fKUDBvn1uk9oSPN1RCutNFkSrQa6GYoh+4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tu3982nBF8pjbRjHeiY2WCAeEnIAc0dUfXP8j921plkp6w/oxyuEkpz1i2bcFbIOMiexDcmGPn6Rey3R1uFARQfwGMNztkEmKhgymZp1X58HLqIUO2WtW4jF2+U0WGAR8HU4MCVUftik2zU024nD4a9WpP2CRpPKKxnjDeSEkrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71A3F1A00; Fri, 27 Jun 2025 06:43:48 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B62A13F66E; Fri, 27 Jun 2025 06:44:03 -0700 (PDT) Date: Fri, 27 Jun 2025 14:44:00 +0100 From: Cristian Marussi To: Peng Fan Cc: Sudeep Holla , Cristian Marussi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] firmware: arm_scmi: imx: Support getting syslog of MISC protocol Message-ID: References: <20250627-sm-misc-api-v1-v1-0-2b99481fe825@nxp.com> <20250627-sm-misc-api-v1-v1-5-2b99481fe825@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250627-sm-misc-api-v1-v1-5-2b99481fe825@nxp.com> On Fri, Jun 27, 2025 at 02:03:48PM +0800, Peng Fan wrote: > MISC protocol supports getting system log regarding system sleep latency > ,wakeup interrupt and etc. Add the API for user to retrieve the > information from SM. > > Signed-off-by: Peng Fan > --- > .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 78 ++++++++++++++++++++++ > include/linux/scmi_imx_protocol.h | 19 ++++++ > 2 files changed, 97 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > index d5b24bc4d4ca6c19f4cddfaea6e9d9b32a4c92f7..1a6d75357b76ce6bb7d06461999b368c27f1fa43 100644 > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > @@ -28,6 +28,7 @@ enum scmi_imx_misc_protocol_cmd { > SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6, > SCMI_IMX_MISC_SI_INFO = 0xB, > SCMI_IMX_MISC_CFG_INFO = 0xC, > + SCMI_IMX_MISC_SYSLOG = 0xD, > SCMI_IMX_MISC_CTRL_NOTIFY = 0x8, > }; > > @@ -87,6 +88,19 @@ struct scmi_imx_misc_si_info_out { > u8 siname[MISC_MAX_SINAME]; > }; > > +struct scmi_imx_misc_syslog_in { > + __le32 flags; > + __le32 index; > +}; > + > +#define REMAINING(x) le32_get_bits((x), GENMASK(31, 20)) > +#define RETURNED(x) le32_get_bits((x), GENMASK(11, 0)) > + > +struct scmi_imx_misc_syslog_out { > + __le32 numlogflags; > + __le32 syslog[]; > +}; > + > static int scmi_imx_misc_attributes_get(const struct scmi_protocol_handle *ph, > struct scmi_imx_misc_info *mi) > { > @@ -368,6 +382,69 @@ static int scmi_imx_misc_silicon_info(const struct scmi_protocol_handle *ph, > return ret; > } > > +struct scmi_imx_misc_syslog_ipriv { > + u32 *array; > +}; > + > +static void iter_misc_syslog_prepare_message(void *message, u32 desc_index, > + const void *priv) > +{ > + struct scmi_imx_misc_syslog_in *msg = message; > + > + msg->flags = cpu_to_le32(0); > + msg->index = cpu_to_le32(desc_index); > +} > + > +static int iter_misc_syslog_update_state(struct scmi_iterator_state *st, > + const void *response, void *priv) > +{ > + const struct scmi_imx_misc_syslog_out *r = response; > + > + st->num_returned = RETURNED(r->numlogflags); > + st->num_remaining = REMAINING(r->numlogflags); > + > + return 0; > +} > + > +static int > +iter_misc_syslog_process_response(const struct scmi_protocol_handle *ph, > + const void *response, > + struct scmi_iterator_state *st, void *priv) > +{ > + const struct scmi_imx_misc_syslog_out *r = response; > + struct scmi_imx_misc_syslog_ipriv *p = priv; > + > + p->array[st->desc_index + st->loop_idx] = > + le32_to_cpu(r->syslog[st->loop_idx]); > + > + return 0; > +} > + > +static int scmi_imx_misc_syslog(const struct scmi_protocol_handle *ph, u16 size, > + void *array) > +{ ...so this size... > + struct scmi_iterator_ops ops = { > + .prepare_message = iter_misc_syslog_prepare_message, > + .update_state = iter_misc_syslog_update_state, > + .process_response = iter_misc_syslog_process_response, > + }; > + struct scmi_imx_misc_syslog_ipriv ipriv = { > + .array = array, > + }; > + void *iter; > + > + if (!array || !size) > + return -EINVAL; > + ...which cannot be zero and is passed down to the iterator as max_resources is meant to repreent also the length of tthe array passed here as an argument and filled-in by the iterators ? ...and so basically array bounds-checking is enforced by the iterators core code, because no matter what, it is always enforced that (returned + remaining <= max_resources (size) ...I am fine with this, I am just trying to understand and see if I can find a mishap :D > + iter = ph->hops->iter_response_init(ph, &ops, size, SCMI_IMX_MISC_SYSLOG, > + sizeof(struct scmi_imx_misc_syslog_in), > + &ipriv); > + if (IS_ERR(iter)) > + return PTR_ERR(iter); > + > + return ph->hops->iter_response_run(iter); > +} > + > static const struct scmi_imx_misc_proto_ops scmi_imx_misc_proto_ops = { > .misc_cfg_info = scmi_imx_misc_cfg_info, > .misc_ctrl_set = scmi_imx_misc_ctrl_set, > @@ -375,6 +452,7 @@ static const struct scmi_imx_misc_proto_ops scmi_imx_misc_proto_ops = { > .misc_ctrl_req_notify = scmi_imx_misc_ctrl_notify, > .misc_discover_build_info = scmi_imx_discover_build_info, > .misc_silicon_info = scmi_imx_misc_silicon_info, > + .misc_syslog = scmi_imx_misc_syslog, > }; > > static int scmi_imx_misc_protocol_init(const struct scmi_protocol_handle *ph) > diff --git a/include/linux/scmi_imx_protocol.h b/include/linux/scmi_imx_protocol.h > index 0e639dfb5d16e281e2ccf006a63694b316c431f4..ff34d974046aa982fa9f5d46fc673412e01a532d 100644 > --- a/include/linux/scmi_imx_protocol.h > +++ b/include/linux/scmi_imx_protocol.h > @@ -71,6 +71,23 @@ struct scmi_imx_misc_system_info { > u8 siname[MISC_MAX_SINAME]; > }; > > +struct scmi_imx_misc_sys_sleep_rec { > + u32 sleepentryusec; > + u32 sleepexitusec; > + u32 sleepcnt; > + u32 wakesource; > + u32 mixpwrstat; > + u32 mempwrstat; > + u32 pllpwrstat; > + u32 syssleepmode; > + u32 syssleepflags; > +}; So where is this used ? later in the series ? > + > +struct scmi_imx_misc_syslog { > + struct scmi_imx_misc_sys_sleep_rec syssleeprecord; > + uint32_t deverrlog; > +}; > + > struct scmi_imx_misc_proto_ops { > int (*misc_cfg_info)(const struct scmi_protocol_handle *ph, > struct scmi_imx_misc_system_info *info); > @@ -84,6 +101,8 @@ struct scmi_imx_misc_proto_ops { > struct scmi_imx_misc_system_info *info); > int (*misc_silicon_info)(const struct scmi_protocol_handle *ph, > struct scmi_imx_misc_system_info *info); > + int (*misc_syslog)(const struct scmi_protocol_handle *ph, u16 size, > + void *array); > }; > Thanks, Cristian