[PATCH 1/2] EDAC/ie31200: Enable support for Core i5-14600 and i7-14700

[PATCH 1/2] EDAC/ie31200: Enable support for Core i5-14600 and i7-14700

[George Gaidarov]

Device ID '0xa740' is shared by i7-14700, i7-14700K, and i7-14700T.
Device ID '0xa704' is shared by i5-14600, i5-14600K, and i5-14600T.

Tested locally on my i7-14700K.

Signed-off-by: George Gaidarov <gdgaidarov+lkml@gmail.com>
---
 drivers/edac/ie31200_edac.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
index 55cf54741aa0..1812ebd19ece 100644
--- a/drivers/edac/ie31200_edac.c
+++ b/drivers/edac/ie31200_edac.c
@@ -90,6 +90,8 @@
 #define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_2	0x4640
 #define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_3	0x4630
 #define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_4	0xa700
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_5	0xa740
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_6	0xa704
 
 /* Alder Lake-S */
 #define PCI_DEVICE_ID_INTEL_IE31200_ADL_S_1	0x4660
@@ -739,6 +741,8 @@ static const struct pci_device_id ie31200_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_2), (kernel_ulong_t)&rpl_s_cfg},
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_3), (kernel_ulong_t)&rpl_s_cfg},
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_4), (kernel_ulong_t)&rpl_s_cfg},
+	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_5), (kernel_ulong_t)&rpl_s_cfg},
+	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_6), (kernel_ulong_t)&rpl_s_cfg},
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_ADL_S_1), (kernel_ulong_t)&rpl_s_cfg},
 	{ 0, } /* 0 terminated list. */
 };

base-commit: ea3b0b7f541b9511abe2b89547c95458804f38e2
-- 
2.49.0

[PATCH 2/2] EDAC/ie31200: Document which CPUs correspond to each Raptor Lake-S device ID

[George Gaidarov]

Based on table 103 ("Host Device ID (DID0)") in [1], document which CPUs
correspond to each Raptor Lake-S device ID for better readability.

[1] https://www.intel.com/content/www/us/en/content-details/743844/13th-generation-intel-core-intel-core-14th-generation-intel-core-processor-series-1-and-series-2-and-intel-xeon-e-2400-processor-datasheet-volume-1-of-2.html

Signed-off-by: George Gaidarov <gdgaidarov+lkml@gmail.com>
---
 drivers/edac/ie31200_edac.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
index 1812ebd19ece..42e332ecd6d0 100644
--- a/drivers/edac/ie31200_edac.c
+++ b/drivers/edac/ie31200_edac.c
@@ -86,12 +86,12 @@
 #define PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_10   0x3eca
 
 /* Raptor Lake-S */
-#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_1	0xa703
-#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_2	0x4640
-#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_3	0x4630
-#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_4	0xa700
-#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_5	0xa740
-#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_6	0xa704
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_1	0xa703 /* 8P+8E,  e.g. i7-13700 */
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_2	0x4640 /* 6P+8E,  e.g. i5-13500, i5-13600, i5-14500 */
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_3	0x4630 /* 4P+0E,  e.g. i3-13100E */
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_4	0xa700 /* 8P+16E, e.g. i9-13900, i9-14900 */
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_5	0xa740 /* 8P+12E, e.g. i7-14700 */
+#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_6	0xa704 /* 6P+8E,  e.g. i5-14600 */
 
 /* Alder Lake-S */
 #define PCI_DEVICE_ID_INTEL_IE31200_ADL_S_1	0x4660
-- 
2.49.0

RE: [PATCH 1/2] EDAC/ie31200: Enable support for Core i5-14600 and i7-14700

[Zhuo, Qiuxu]

> From: George Gaidarov <gdgaidarov@gmail.com> On Behalf Of George
> Gaidarov
> Sent: Friday, May 30, 2025 12:30 AM
> To: Luck, Tony <tony.luck@intel.com>; Borislav Petkov <bp@alien8.de>; Jason
> Baron <jbaron@akamai.com>
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; Zhuo, Qiuxu
> <qiuxu.zhuo@intel.com>; Mauro Carvalho Chehab <mchehab@kernel.org>;
> James Morse <james.morse@arm.com>; Robert Richter <rric@kernel.org>;
> George Gaidarov <gdgaidarov+lkml@gmail.com>
> Subject: [PATCH 1/2] EDAC/ie31200: Enable support for Core i5-14600 and i7-
> 14700
> 
> Device ID '0xa740' is shared by i7-14700, i7-14700K, and i7-14700T.
> Device ID '0xa704' is shared by i5-14600, i5-14600K, and i5-14600T.
> 
> Tested locally on my i7-14700K.
> 
> Signed-off-by: George Gaidarov <gdgaidarov+lkml@gmail.com>

George sent me the log offline, showing the successful loading of the 
ie31200_edac driver with these RPL-S compute die IDs, confirming that 
these RPL-S CPUs have ECC capability. 

   Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

RE: [PATCH 2/2] EDAC/ie31200: Document which CPUs correspond to each Raptor Lake-S device ID

[Zhuo, Qiuxu]

> From: George Gaidarov <gdgaidarov@gmail.com> On Behalf Of George
> Gaidarov
> Sent: Friday, May 30, 2025 12:30 AM
> To: Luck, Tony <tony.luck@intel.com>; Borislav Petkov <bp@alien8.de>; Jason
> Baron <jbaron@akamai.com>
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; Zhuo, Qiuxu
> <qiuxu.zhuo@intel.com>; Mauro Carvalho Chehab <mchehab@kernel.org>;
> James Morse <james.morse@arm.com>; Robert Richter <rric@kernel.org>;
> George Gaidarov <gdgaidarov+lkml@gmail.com>
> Subject: [PATCH 2/2] EDAC/ie31200: Document which CPUs correspond to
> each Raptor Lake-S device ID
> 
> Based on table 103 ("Host Device ID (DID0)") in [1], document which CPUs
> correspond to each Raptor Lake-S device ID for better readability.
> 
> [1] https://www.intel.com/content/www/us/en/content-details/743844/13th-
> generation-intel-core-intel-core-14th-generation-intel-core-processor-series-
> 1-and-series-2-and-intel-xeon-e-2400-processor-datasheet-volume-1-of-
> 2.html
> 
> Signed-off-by: George Gaidarov <gdgaidarov+lkml@gmail.com>

LGTM. Thanks.

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

Re: [PATCH 1/2] EDAC/ie31200: Enable support for Core i5-14600 and i7-14700

[Luck, Tony]

On Thu, May 29, 2025 at 04:29:32PM +0000, George Gaidarov wrote:
> Device ID '0xa740' is shared by i7-14700, i7-14700K, and i7-14700T.
> Device ID '0xa704' is shared by i5-14600, i5-14600K, and i5-14600T.
> 
> Tested locally on my i7-14700K.
> 

George,

Applied to the edac-drivers branch of the RAS tree[1]

Should be picked up by linux-next, and will be merged into v6.17

Thanks

-Tony

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git

Re: [PATCH 2/2] EDAC/ie31200: Document which CPUs correspond to each Raptor Lake-S device ID

[Luck, Tony]

On Thu, May 29, 2025 at 04:29:33PM +0000, George Gaidarov wrote:
> Based on table 103 ("Host Device ID (DID0)") in [1], document which CPUs
> correspond to each Raptor Lake-S device ID for better readability.
> 
> [1] https://www.intel.com/content/www/us/en/content-details/743844/13th-generation-intel-core-intel-core-14th-generation-intel-core-processor-series-1-and-series-2-and-intel-xeon-e-2400-processor-datasheet-volume-1-of-2.html
> 

George,

Ditto. Merged as for part 1.

Thanks

-Tony