* [PATCH] soundwire: debugfs: initialize ktime_t variables before div_u64
@ 2025-06-17 1:48 Rodrigo Gobbi
2025-06-17 5:29 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Rodrigo Gobbi @ 2025-06-17 1:48 UTC (permalink / raw)
To: vkoul, yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale
Cc: ~lkcamp/patches, linux-sound, linux-kernel
The start_t and finish_t variables are not properly initialized
if errors happens over request_firmware actions. This was also detected by smatch:
drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'finish_t'.
drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'start_t'.
Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-sound/0db6d0bf-7bac-43a7-b624-a00d3d2bf829@stanley.mountain/
Fixes: bb5cb09eedce ("soundwire: debugfs: add interface for BPT/BRA transfers")
---
drivers/soundwire/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
index 3099ea074f10..951fc255e4eb 100644
--- a/drivers/soundwire/debugfs.c
+++ b/drivers/soundwire/debugfs.c
@@ -237,8 +237,8 @@ static int cmd_go(void *data, u64 value)
{
const struct firmware *fw = NULL;
struct sdw_slave *slave = data;
- ktime_t start_t;
- ktime_t finish_t;
+ ktime_t start_t = 0;
+ ktime_t finish_t = 0;
int ret;
if (value != 1)
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soundwire: debugfs: initialize ktime_t variables before div_u64
2025-06-17 1:48 [PATCH] soundwire: debugfs: initialize ktime_t variables before div_u64 Rodrigo Gobbi
@ 2025-06-17 5:29 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2025-06-17 5:29 UTC (permalink / raw)
To: Rodrigo Gobbi
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
~lkcamp/patches, linux-sound, linux-kernel
On 16-06-25, 22:48, Rodrigo Gobbi wrote:
> The start_t and finish_t variables are not properly initialized
> if errors happens over request_firmware actions. This was also detected by smatch:
>
> drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'finish_t'.
> drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'start_t'.
Should we care about debug statement printing wrong time on error...
Rather than do this, better to move debug statement up so that it is not
executed on error scenario
>
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/linux-sound/0db6d0bf-7bac-43a7-b624-a00d3d2bf829@stanley.mountain/
> Fixes: bb5cb09eedce ("soundwire: debugfs: add interface for BPT/BRA transfers")
> ---
> drivers/soundwire/debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
> index 3099ea074f10..951fc255e4eb 100644
> --- a/drivers/soundwire/debugfs.c
> +++ b/drivers/soundwire/debugfs.c
> @@ -237,8 +237,8 @@ static int cmd_go(void *data, u64 value)
> {
> const struct firmware *fw = NULL;
> struct sdw_slave *slave = data;
> - ktime_t start_t;
> - ktime_t finish_t;
> + ktime_t start_t = 0;
> + ktime_t finish_t = 0;
> int ret;
>
> if (value != 1)
> --
> 2.49.0
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 1:48 [PATCH] soundwire: debugfs: initialize ktime_t variables before div_u64 Rodrigo Gobbi
2025-06-17 5:29 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).