From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E7911CD3F for ; Thu, 19 Jun 2025 01:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750297419; cv=none; b=FW2cGnZQ+4nbBQmtxeAwhPPW2+TiJnv9dD0ieFfLBgDkv4LwUMYOyFBfbQtlvgAyUV2I8OUd/RI52b3tVSweZGNdneyNmAlM8haXFq2OJK0xnQe+/adbmpEvQ9KSpWG2o+BciX/2xFBkXJd1VUNhPekyBB/+ea2Lf95OZ5BqkWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750297419; c=relaxed/simple; bh=dLjiGbT9JPWGVFlw+MuDObZxogfa330xuB5+6m+uoVI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OnuniPs9WgR/NOj92fkVO0Pz7tkRdri84301wz/0h75I/4eZWG8lJlSxPzDntu9QVTYa/EzwVFdmhI8zD3Oq/b6UKEvpfTWUEORdOMIdHz80GTzHg7HbQgwhb/g68pCnp4+9Kcm3vvo+DtloO0XHQ3B3wCnVeWOgyynCFH8Ayiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=Aa8KVzM6; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="Aa8KVzM6" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-748feca4a61so8111b3a.3 for ; Wed, 18 Jun 2025 18:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1750297417; x=1750902217; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9RBzLiRa5kP007xKu/khAw6xLYgVFKSnX02dITEELMQ=; b=Aa8KVzM6GHceqv3r1o2xB6qGuOFlRsFM/KwnrmcjPvfeGVYy6f9BWEeS5GStj6Cx6q wcSz2x9+9KUsXwPr2TSIcQCOubBQiEUMbD4gQhMKldxfvZyU9601jQfi6FuKnCeBcrot Bvehey7MAOHyp5RXqHuPOdxveNobC6hHslUYTmADU1r2s1j+wJrPfHLlAfjjlBjJUQ6u rpuXcbGWAd+6o5MJKcvf0NDiFr/hxKgmFcWnbYO2ehktiLTX54p75HwXj65crUGdej77 uvOyZIzLTPKp4DAsCa2Tj9LpkejskolFXcV+rbM/GJkuRcZjMpqtqof6c040HVbHZZ+P Padw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750297417; x=1750902217; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9RBzLiRa5kP007xKu/khAw6xLYgVFKSnX02dITEELMQ=; b=oBrm4JaZNvtvGvuLoJ2K8/wSPExuz6tJ3i/cpECfuqcpt3SPjuCGo3xrI8Txbo5MnA eKBIeqGv5i8C/FyU0T1GAIks9nBg/ll0gLkhTML3y3di5WoVNQMdsvtk9OU6taF0wemP Ans7LQc+tD5A1xeAIkb+/VE+HOh+2PPyOFVLPfzRQe85rVxI9UHjYztr6sODQa9JNqDx nR6rjfdQCJXSBG8KwdvbwWqu+Cg/kDvPQ6R6LfjwYRNqXfOWDds8I61IzUA1ZQtYe9yR XYJ8N5PfPZ1lhjo9UqNCcywFx4RxhZIf825G4HWnmrudih7O+WdepA/WFxXJ5nqWJCQd lx4g== X-Forwarded-Encrypted: i=1; AJvYcCUFuRBl8OYEB7JmHgD0vgezyIgWtwwSKuaaG518Tf/H53x5dTW/LPztsjUi6rsQLBsXxECITzKot1kI+4Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyRB+R/oRs5LTdA+zUePbvDzAmOhToTgHvfpWKMrbIaxgiCfO6h sXNCQFWnr5JqKcx+BzGUtZHBmlYCMXbdyW9O/7ZLeUbyVlYIp4NTXb1h4UzuZJLKGag= X-Gm-Gg: ASbGncs58VAb6KJ/BNd0aIJV3nsr/qfYMMuqAwHE4UFPSJ0ZNQdpE799/L5xbDrsPAl FtTPWJ6vQ9ala1izDKcCDfsEVCzzBingjNdyOyjscYTVgScs0m05yUtjSlyUIahVqSzcBNYL0RH q0iZRjfEHd0rVZdKp2QK8IChCMboxyVHrNsnGS3jcj5qcvsp8al+oaw4iTi6Hx5HShethp8HKcQ dstoGu6855EuDT6Zum6rGOu22azz/FP7zaGDEaLCF0CFNTv9zJeeP64InAUXR7uP92Otpi1Z5fh gbVfzFAXfGYPoFlS9p7O34hObCLbgzFZ7GjfAiXFpa5kd3XbrrgA2gH+SGuYlj45XH6w8Mc= X-Google-Smtp-Source: AGHT+IER1GlKqenGCJq3qD2Xqlv8+ahed3DymdmXx7TwJgKJZxq18ZlqN5MmHKY9e5pztJs0I4bquQ== X-Received: by 2002:a05:6a00:178e:b0:742:ae7e:7da8 with SMTP id d2e1a72fcca58-7489ce45893mr32194637b3a.8.1750297417247; Wed, 18 Jun 2025 18:43:37 -0700 (PDT) Received: from x1 (97-120-250-80.ptld.qwest.net. [97.120.250.80]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748fbce0f13sm291934b3a.37.2025.06.18.18.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 18:43:36 -0700 (PDT) Date: Wed, 18 Jun 2025 18:43:34 -0700 From: Drew Fustini To: Michal Wilczynski Cc: Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Philipp Zabel , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Ulf Hansson , Marek Szyprowski , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, Krzysztof Kozlowski Subject: Re: [PATCH v5 0/8] Add TH1520 GPU support with power sequencing Message-ID: References: <20250618-apr_14_for_sending-v5-0-27ed33ea5c6f@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618-apr_14_for_sending-v5-0-27ed33ea5c6f@samsung.com> On Wed, Jun 18, 2025 at 12:22:06PM +0200, Michal Wilczynski wrote: > This patch series introduces support for the Imagination IMG BXM-4-64 > GPU found on the T-HEAD TH1520 SoC. A key aspect of this support is > managing the GPU's complex power-up and power-down sequence, which > involves multiple clocks and resets. > > The TH1520 GPU requires a specific sequence to be followed for its > clocks and resets to ensure correct operation. Initial discussions and > an earlier version of this series explored managing this via the generic > power domain (genpd) framework. However, following further discussions > with kernel maintainers [1], the approach has been reworked to utilize > the dedicated power sequencing (pwrseq) framework. > > This revised series now employs a new pwrseq provider driver > (pwrseq-thead-gpu.c) specifically for the TH1520 GPU. This driver > encapsulates the SoC specific power sequence details. The Imagination > GPU driver (pvr_device.c) is updated to act as a consumer of this power > sequencer, requesting the "gpu-power" target. The sequencer driver, > during its match phase with the GPU device, acquires the necessary clock > and reset handles from the GPU device node to perform the full sequence. > > This approach aligns with the goal of abstracting SoC specific power > management details away from generic device drivers and leverages the > pwrseq framework as recommended. > > The series is structured as follows: > > Patch 1: Introduces the pwrseq-thead-gpu auxiliary driver to manage the > GPU's power-on/off sequence. > Patch 2: Adds device tree bindings for the gpu-clkgen reset to the > existing thead,th1520-aon binding. > Patch 3: Extends the pm-domains driver to detect the gpu-clkgen reset > and spawn the pwrseq-thead-gpu auxiliary driver. > Patch 4: Updates the Imagination DRM driver to utilize the pwrseq > framework for TH1520 GPU power management. > Patch 5: Adds the thead,th1520-gpu compatible string to the PowerVR GPU > device tree bindings. > Patch 6: Adds the gpu-clkgen reset property to the aon node in the > TH1520 device tree source. > Patch 7: Adds the device tree node for the IMG BXM-4-64 GPU and its > required fixed-clock. > Patch 8: Enables compilation of the Imagination PowerVR driver on the > RISC-V architecture. > > This patchset finishes the work started in bigger series [2] by adding > all remaining GPU power sequencing piece. After this patchset the GPU > probes correctly. The powevr probe complains: [ 1.060383] powervr ffef400000.gpu: Direct firmware load for powervr/rogue_36.52.104.182_v1.fw failed with error -2 Where is the correct place to get the firmware? Thanks, Drew