From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0BB927876A for ; Thu, 19 Jun 2025 09:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324486; cv=none; b=pUBqcGuL2yvCPD2j2Pr5xy/YQl+bs6X0FfDoRQ89pflMlk5KDVvjYqG0JVXKQriK1Rx+ddzSlWy8I6w6XkYaBzVTC44t9/j5rewL6b1xcg+IEAiirXeJPyJQsuhLTtLE79GMA+5dSFXTmku4yvsCOGUaCMNldQPggYEEEHA2E8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324486; c=relaxed/simple; bh=oskZaqewOdI9Q2vgMTv3V9kHOUv/J7lvDhpMHUc35DM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WoNwCayslgnDUkGcwxG8uX1iZcbvfMAdFjZpfOfzCHfUUU5IGvEjEJg/HksdNwdP0KgJvgOo7BKZ1DxucaEw0DLZ2o/EXnCMu+kxSmgwoC/b2T+G9kMqf1NL8D0vPc8ZxJQl9rUJy1ZtARkZIAgEAjY/aeKnXJxGkYAsixd1Kbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Dv7WycaE; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Dv7WycaE" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2357c61cda7so88065ad.1 for ; Thu, 19 Jun 2025 02:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750324482; x=1750929282; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oWamqH4Qzt1P4RdD6HP7YstMpMkIZRoPsNcDiTnzqKM=; b=Dv7WycaEyXueQqTKSG90D4rovykObav7TJQAiW1sEQx62haVBoBiKX3WPYyRQBbGbL 8hZQXnpKZanDb5N1CltTayyBnZL1BJQFHkD4g/0176tSaXpCkvuONuc96qP6MNWqXh5r lTPO192S9TTYxQCYs/ux9DTLUS0k7TyDDONPZPnoa68NR9CIPyEQHkTtVKD1nrSLp2k3 TFRNJdq0uTJQSHHiHWXKeGSL9EHLAIMgm8zIfcYh+YGyaHCDakyBqNIsSSWgYGRcZKCC RcNfpO84uh0nqkK5B1uERm1X1RvUbC2bpLnBkrRF8TPJiUg7AK1LuGYqQeW8FEM+c579 9Zxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750324482; x=1750929282; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oWamqH4Qzt1P4RdD6HP7YstMpMkIZRoPsNcDiTnzqKM=; b=hEg4TPh/iwAczoFgm1WpYutUpa6cDWWuOWzH1K5YRtIe+96B1hONoGC90v4uuzMYHC q0HuDsDELkzNhJY99uRoMB+vxfbxNqIBVAvjxFsL2PJ9+z2Vzw7XNhNKvnljGKbKtZfW NQ6EUP9LzgTDUK4slPatWurQ023crdLBw+kLhHFofNRC2dDJiJqKD51qfALI7pcNAyYy xJnCF5Ii2tJIiO6pEuhf482AHBmUHgrsrMM2DZlr6xRJdHsSKOfut+w/DMK1pjmz7I1v EVxLE/9VH8mBvBOkoQ5SaDj2vYyBNJuMSjyJs9gklKC1AzKT6IWjYgWp6bU9kvZ+ACJO DHhQ== X-Forwarded-Encrypted: i=1; AJvYcCUKNsBtbX1+YtzIARH/SMK7ANY4vf8PFbIVUGqeDrXW7tIQMrujv/2USssllr+ZQhKWoO3sKRnGdBxxGuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwfXsNkpHNN552lEutE/AnF7WBxOwCl+AXR0egNvXolWjsWRDQc YoXsUPj7bdS9wjk1buYrq2j2++efE88Wrtyzqv1qPtJ1dYyWeA4bZMC+BuWhhCZd7g== X-Gm-Gg: ASbGncsmv1lgI5ueAtDc/Z+Zhd+nEvZSMJnnjMTLH5VgdKk889wasJo86i7D1NgrHez pG1o+M05p2M760SptfnI3MH5ciDUc923JPWpgiWEpL+GWQm15FFzKn8N1lzm0e+cOT9WA6cCXH/ YDfU2GZQINUFwJkUCHTOhgL1MqS0SZfZtyp/QjwKmn/T5QdZvDdKPRHqv5GaDeZgx48O30vN4HN usbGHRevU+JJ4I9PzMOJReiq8OYr9ZRphg2F4P8yOqDi+yyY/oLroJ/Gh9NyY0zTvmHpX626P/3 kmShXIpGjrJAI/C2CTeo+WQmpL8C55H78dnWaXhpHhBBImSLlxi/EdaoLruNIl6B4UDmZKNa96y knjy6GT3asS425R9c6Xu7 X-Google-Smtp-Source: AGHT+IEvh8ntAaeawSzvvAW9v54xfOai3SDk6b1VSkUWtSTdDIzpJHZdPCeE04W9I0TDOLd777OhYA== X-Received: by 2002:a17:902:da48:b0:234:13ad:7f9f with SMTP id d9443c01a7336-237ccb4af65mr2441805ad.22.1750324481903; Thu, 19 Jun 2025 02:14:41 -0700 (PDT) Received: from google.com (232.98.126.34.bc.googleusercontent.com. [34.126.98.232]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d88c029sm114860565ad.26.2025.06.19.02.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 02:14:41 -0700 (PDT) Date: Thu, 19 Jun 2025 09:14:29 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: Jason Gunthorpe , kevin.tian@intel.com, corbet@lwn.net, will@kernel.org, bagasdotme@gmail.com, robin.murphy@arm.com, joro@8bytes.org, thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, shuah@kernel.org, jsnitsel@redhat.com, nathan@kernel.org, peterz@infradead.org, yi.l.liu@intel.com, mshavit@google.com, zhangzekun11@huawei.com, iommu@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, mochs@nvidia.com, alok.a.tiwari@oracle.com, vasant.hegde@amd.com, dwmw2@infradead.org, baolu.lu@linux.intel.com Subject: Re: [PATCH v6 06/25] iommufd/access: Allow access->ops to be NULL for internal use Message-ID: References: <20250616133305.GB1174925@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 16, 2025 at 07:21:28PM -0700, Nicolin Chen wrote: > On Mon, Jun 16, 2025 at 10:33:05AM -0300, Jason Gunthorpe wrote: > > On Sat, Jun 14, 2025 at 12:14:31AM -0700, Nicolin Chen wrote: > > > @@ -1321,7 +1328,7 @@ int iommufd_access_pin_pages(struct iommufd_access *access, unsigned long iova, > > > > > > /* Driver's ops don't support pin_pages */ > > > if (IS_ENABLED(CONFIG_IOMMUFD_TEST) && > > > - WARN_ON(access->iova_alignment != PAGE_SIZE || !access->ops->unmap)) > > > + WARN_ON(access->iova_alignment != PAGE_SIZE)) > > > return -EINVAL; > > > > I don't want to loose this check, continuing blocking mdevs is still > > important. Only the internal access should be able to use this > > mechanism. > > OK. So, it probably should be > if (IS_ENABLED(CONFIG_IOMMUFD_TEST) && > WARN_ON(access->iova_alignment != PAGE_SIZE || > (access->ictx && !access->ops->unmap)) > Nit: Probably worth mentioning in a comment that access->ops shouldn't be NULL during selftests and hence we avoid checking for !access->ops? If you feel it's too verbose, you can let be as well. Reviewed-by: Pranjal Shrivastava > Thanks > Nicolin