From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3FF2857D5; Fri, 20 Jun 2025 10:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750415540; cv=none; b=ZBav739AvA0kdp4A4xBA1855+JLiU0i5MkKEVSVWXgsPq5kNA31vxwb5Yb84RVL0KuLy+NnYPf9WXotDBUSZAXKtfjEjPxkYcYV7RJtHyM81oysWRCSALx4bg8LZLxzLclROha1e3zes2KstII9n+/UcZsiAehMZ8NrR0hK2af0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750415540; c=relaxed/simple; bh=xY3tmpVZXtdrtEJ7ftibxt61YM3ggS0t1zqb59MR6vQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GQKNBQrj2+etw8i0SPR2Yx6AvvZvf1oIJObttD0rrz69Wb1I847XI5osaRLjS3y2y35MOtNp0CUXaNPnD7HetDtpiNbq8CPEcQ+BYyNdpSDvd3GDaUxR70XjoO30ZV53kGoMvIQT7Z31z1FPzQOzB7/YEDXfOrrBQq8DqRKt7Ec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1uSYtp-0000000076t-3nSw; Fri, 20 Jun 2025 10:31:51 +0000 Date: Fri, 20 Jun 2025 12:31:41 +0200 From: Daniel Golle To: Frank Wunderlich Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Jia-Wei Chang , Johnson Wang , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Landen Chao , DENG Qingfang , Sean Wang , Lorenzo Bianconi , Felix Fietkau , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v5 01/13] dt-bindings: net: mediatek,net: update for mt7988 Message-ID: References: <20250620083555.6886-1-linux@fw-web.de> <20250620083555.6886-2-linux@fw-web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620083555.6886-2-linux@fw-web.de> On Fri, Jun 20, 2025 at 10:35:32AM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Update binding for mt7988 which has 3 gmac and 2 reg items. > > MT7988 has 4 FE IRQs (currently only 2 are used) and the 4 IRQs for > use with RSS/LRO later. > > Add interrupt-names to make them accessible by name. > > Signed-off-by: Frank Wunderlich > --- > v5: > - fix v4 logmessage and change description a bit describing how i get > the irq count. > - update binding for 8 irqs with different names (rx,tx => fe0..fe3) > including the 2 reserved irqs which can be used later > - change rx-ringX to pdmaX to be closer to hardware documentation > > v4: > - increase max interrupts to 6 because of adding RSS/LRO interrupts (4) > and dropping 2 reserved irqs (0+3) around rx+tx > - dropped Robs RB due to this change > - allow interrupt names > - add interrupt-names without reserved IRQs on mt7988 > this requires mtk driver patch: > https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ > > v2: > - change reg to list of items > --- > .../devicetree/bindings/net/mediatek,net.yaml | 30 ++++++++++++++++--- > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml > index 9e02fd80af83..9465b40683ad 100644 > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml > @@ -28,7 +28,10 @@ properties: > - ralink,rt5350-eth > > reg: > - maxItems: 1 > + items: > + - description: Register for accessing the MACs. > + - description: SoC internal SRAM used for DMA operations. > + minItems: 1 > > clocks: > minItems: 2 > @@ -40,7 +43,11 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 4 > + maxItems: 8 > + > + interrupt-names: > + minItems: 1 > + maxItems: 8 Shouldn't interrupt-names only be required for MT7988 (and future SoCs)? Like this at least one entry in interrupt-names is now always required.