linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, ast@kernel.org
Subject: Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test
Date: Fri, 20 Jun 2025 01:39:43 -0700	[thread overview]
Message-ID: <aFUeT8HSPYiDyALB@gmail.com> (raw)
In-Reply-To: <20250613174233.0dd5e7c1@kernel.org>

On Fri, Jun 13, 2025 at 05:42:33PM -0700, Jakub Kicinski wrote:
> On Fri, 13 Jun 2025 05:47:50 -0700 Breno Leitao wrote:
> > > Or is there another way that the packets could be observed, e.g.,
> > > counters.  
> > 
> > Unfortunately netpoll doesn't expose any data, thus, it is hard to get
> > it. 
> > 
> > I have plans to create a configfs for netpoll, so, we can check for
> > these numbers (as also configure some pre-defined values today, such as
> > USEC_PER_POLL, MAX_SKBS, ip6h->version = 6; ip6h->priority = 0, etc.
> > 
> > In fact, I've an private PoC for this, but, I am modernizing the code
> > first, and creating some selftests to help me with those changes later
> > (given we have very little test on netpoll, and I aim to improve this,
> > given how critical it is for some datacenter designs).
> 
> FWIW you can steal bpftrace integration from this series:
> https://lore.kernel.org/all/20250421222827.283737-22-kuba@kernel.org/

Yes, that would be great. I think we can iterate until we hit the poll
path, otherwise we skip the test at timeout. Something as:

	while (true):
		send msg
		if netpoll_poll_dev() was invoked:
			ksft_exit
		
		if timeout:
			raise KsftSkipEx
	
As soon as your code lands, I will adapt the test to do so. Meanwhile,
I will send the v1 for the netpoll, and later we can iterate.

Thanks for working on this bfptrace helper. This will be useful on other
usecases as well.

--breno

  reply	other threads:[~2025-06-20  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 16:49 [PATCH net-next RFC] selftests: net: add netpoll basic functionality test Breno Leitao
2025-06-13  2:35 ` Willem de Bruijn
2025-06-13 12:47   ` Breno Leitao
2025-06-13 13:43     ` Willem de Bruijn
2025-06-13 14:07       ` Breno Leitao
2025-06-14  0:42     ` Jakub Kicinski
2025-06-20  8:39       ` Breno Leitao [this message]
2025-06-21 13:51         ` Jakub Kicinski
2025-06-23  9:16           ` Breno Leitao
2025-06-23 17:29             ` Jakub Kicinski
2025-06-23 17:44               ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFUeT8HSPYiDyALB@gmail.com \
    --to=leitao@debian.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).