* [PATCH] drm/msm/dp: include linux/io.h
@ 2025-06-20 12:47 Arnd Bergmann
2025-06-20 13:40 ` Abel Vesa
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-06-20 12:47 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, David Airlie, Simona Vetter,
Stephen Boyd
Cc: Arnd Bergmann, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Abel Vesa, Jani Nikula, Aleksandrs Vinarskis,
linux-arm-msm, dri-devel, freedreno, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The driver started using readl/writel, which are defined in linux/io.h,
so this needs to be included here:
drivers/gpu/drm/msm/dp/dp_panel.c:33:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
33 | return readl_relaxed(panel->link_base + offset);
Fixes: 9d47325ee063 ("drm/msm/dp: drop the msm_dp_catalog module")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index 489e39f6c0ac..ecd5d3665541 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -2,6 +2,7 @@
/*
* Copyright (c) 2012-2020, The Linux Foundation. All rights reserved.
*/
+#include <linux/io.h>
#include "dp_panel.h"
#include "dp_reg.h"
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm/dp: include linux/io.h
2025-06-20 12:47 [PATCH] drm/msm/dp: include linux/io.h Arnd Bergmann
@ 2025-06-20 13:40 ` Abel Vesa
0 siblings, 0 replies; 2+ messages in thread
From: Abel Vesa @ 2025-06-20 13:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rob Clark, Dmitry Baryshkov, David Airlie, Simona Vetter,
Stephen Boyd, Arnd Bergmann, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Jani Nikula, Aleksandrs Vinarskis,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 25-06-20 14:47:43, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver started using readl/writel, which are defined in linux/io.h,
> so this needs to be included here:
>
> drivers/gpu/drm/msm/dp/dp_panel.c:33:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 33 | return readl_relaxed(panel->link_base + offset);
>
> Fixes: 9d47325ee063 ("drm/msm/dp: drop the msm_dp_catalog module")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-20 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 12:47 [PATCH] drm/msm/dp: include linux/io.h Arnd Bergmann
2025-06-20 13:40 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).