From: Kisub Choe <kisub.choe.0x1@gmail.com>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
dan.carpenter@linaro.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kisub.choe.0x1@gmail.com
Subject: [PATCH] staging: rtl8723bs: replace msleep(1)
Date: Sun, 22 Jun 2025 08:28:16 +0900 [thread overview]
Message-ID: <aFdAEM6GnCudvqMV@zinc> (raw)
changed msleep to usleep_range to
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: msleep < 20ms can sleep for up to 20ms;
see function description of msleep().
Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 6a2583d0d3eb..82e77cd8d80c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -7,6 +7,7 @@
#include <drv_types.h>
#include <hal_data.h>
#include <linux/jiffies.h>
+#include <linux/delay.h>
void _ips_enter(struct adapter *padapter)
{
@@ -424,7 +425,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
err = -1;
break;
}
- msleep(1);
+ usleep_range(900, 1000);
}
return err;
@@ -581,7 +582,7 @@ void LPS_Leave_check(struct adapter *padapter)
if (jiffies_to_msecs(jiffies - start_time) > 100)
break;
- msleep(1);
+ usleep_range(900, 1000);
}
}
--
2.34.1
next reply other threads:[~2025-06-21 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 23:28 Kisub Choe [this message]
2025-06-23 10:54 ` [PATCH] staging: rtl8723bs: replace msleep(1) Dan Carpenter
2025-06-23 14:35 ` Kisub Choe
2025-06-23 15:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFdAEM6GnCudvqMV@zinc \
--to=kisub.choe.0x1@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox