[PATCH v2 4/4] rust: devres: implement register_release()

Danilo Krummrich
2025-06-22T16:41:38Z

register_release() is useful when a device resource has associated data,
but does not require the capability of accessing it or manually releasing
it.

If we would want to be able to access the device resource and release the
device resource manually before the device is unbound, but still keep
access to the associated data, we could implement it as follows.

struct Registration<T> {
inner: Devres<RegistrationInner>,
data: T,
}

However, if we never need to access the resource or release it manually,
register_release() is great optimization for the above, since it does not
require the synchronization of the Devres type.

Suggested-by: Alice Ryhl <aliceryhl@google.com>
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
rust/kernel/devres.rs | 84 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 84 insertions(+)

diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
index 15a0a94e992b..4b61e94d34a0 100644
--- a/rust/kernel/devres.rs
+++ b/rust/kernel/devres.rs
@@ -16,6 +16,7 @@
sync::{rcu, Completion},
types::{ARef, ForeignOwnable, Opaque},
};
+use core::ops::Deref;

use pin_init::Wrapper;

@@ -345,3 +346,86 @@ pub fn register<T, E>(dev: &Device<Bound>, data: impl PinInit<T, E>, flags: Flag

register_foreign(dev, data)
}
+
+/// [`Devres`]-releaseable resource.
+///
+/// Register an object implementing this trait with [`register_release`]. Its `release`
+/// function will be called once the device is being unbound.
+pub trait Release {
+ /// Called once the [`Device`] given to [`register_release`] is unbound.
+ fn release(&self);
+}
+
+impl<T: Release> Release for crate::sync::ArcBorrow<'_, T> {
+ fn release(&self) {
+ self.deref().release();
+ }
+}
+
+impl<T: Release> Release for Pin<&'_ T> {
+ fn release(&self) {
+ self.deref().release();
+ }
+}
+
+/// Consume the `data`, [`Release::release`] and [`Drop::drop`] `data` once `dev` is unbound.
+///
+/// # Examples
+///
+/// ```no_run
+/// use kernel::{device::{Bound, Device}, devres, devres::Release, sync::Arc};
+///
+/// /// Registration of e.g. a class device, IRQ, etc.
+/// struct Registration<T> {
+/// data: T,
+/// }
+///
+/// impl<T> Registration<T> {
+/// fn new(data: T) -> Result<Arc<Self>> {
+/// // register
+///
+/// Ok(Arc::new(Self { data }, GFP_KERNEL)?)
+/// }
+/// }
+///
+/// impl<T> Release for Registration<T> {
+/// fn release(&self) {
+/// // unregister
+/// }
+/// }
+///
+/// fn from_bound_context(dev: &Device<Bound>) -> Result {
+/// let reg = Registration::new(0x42)?;
+///
+/// devres::register_release(dev, reg.clone())
+/// }
+/// ```
+pub fn register_release (dev: &Device<Bound>, data: P) -> Result
+where
+ P: ForeignOwnable,
+ for<'a> P::Borrowed<'a>: Release,
+{
+ let ptr = data.into_foreign();
+
+ #[allow(clippy::missing_safety_doc)]
+ unsafe extern "C" fn callback (ptr: *mut kernel::ffi::c_void)
+ where
+ P: ForeignOwnable,
+ for<'a> P::Borrowed<'a>: Release,
+ {
+ // SAFETY: `ptr` is the pointer to the `ForeignOwnable` leaked above and hence valid.
+ unsafe { P::borrow(ptr.cast()) }.release();
+
+ // SAFETY: `ptr` is the pointer to the `ForeignOwnable` leaked above and hence valid.
+ let _ = unsafe { P::from_foreign(ptr.cast()) };
+ }
+
+ // SAFETY:
+ // - `dev.as_raw()` is a pointer to a valid and bound device.
+ // - `ptr` is a valid pointer the `ForeignOwnable` devres takes ownership of.
+ to_result(unsafe {
+ // `devm_add_action_or_reset()` also calls `callback` on failure, such that the
+ // `ForeignOwnable` is released eventually.
+ bindings::devm_add_action_or_reset(dev.as_raw(), Some(callback:: ), ptr.cast())
+ })
+}
--
2.49.0