Re: [PATCH v2 1/4] rust: revocable: support fallible PinInit types

Benno Lossin
2025-06-22T20:23:30Z

On Sun Jun 22, 2025 at 6:40 PM CEST, Danilo Krummrich wrote:
> Currently, Revocable::new() only supports infallible PinInit
> implementations, i.e. impl PinInit<T, Infallible>.
>
> This has been sufficient so far, since users such as Devres do not
> support fallibility.
>
> Since this is about to change, make Revocable::new() generic over the
> error type E.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Benno Lossin <lossin@kernel.org>

---
Cheers,
Benno

> ---
> rust/kernel/devres.rs | 2 +-
> rust/kernel/revocable.rs | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)