From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anup Patel <apatel@ventanamicro.com>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Len Brown" <lenb@kernel.org>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Rahul Pathak" <rpathak@ventanamicro.com>,
"Leyfoon Tan" <leyfoon.tan@starfivetech.com>,
"Atish Patra" <atish.patra@linux.dev>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Samuel Holland" <samuel.holland@sifive.com>,
"Anup Patel" <anup@brainfault.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 13/23] ACPI: property: Refactor acpi_fwnode_get_reference_args()
Date: Mon, 23 Jun 2025 12:08:31 +0300 [thread overview]
Message-ID: <aFkZj2QCU2LfTI30@smile.fi.intel.com> (raw)
In-Reply-To: <20250618121358.503781-14-apatel@ventanamicro.com>
On Wed, Jun 18, 2025 at 05:43:48PM +0530, Anup Patel wrote:
>
> Currently acpi_fwnode_get_reference_args() calls the public function
> __acpi_node_get_property_reference() which ignores the nargs_prop
> parameter. To fix this, make __acpi_node_get_property_reference() to
> call the static acpi_fwnode_get_reference() so that callers of
> fwnode_get_reference_args() can still pass a valid property name to
> fetch the number of arguments.
Looks okay to me, but I think it's better to have more eyes here (Mika,
Rafael?).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-23 9:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 12:13 [PATCH v6 00/23] Linux SBI MPXY and RPMI drivers Anup Patel
2025-06-18 12:13 ` [PATCH v6 01/23] dt-bindings: mailbox: Add bindings for RPMI shared memory transport Anup Patel
2025-06-18 12:13 ` [PATCH v6 02/23] dt-bindings: mailbox: Add bindings for RISC-V SBI MPXY extension Anup Patel
2025-06-18 12:13 ` [PATCH v6 03/23] RISC-V: Add defines for the SBI message proxy extension Anup Patel
2025-06-24 6:58 ` Atish Patra
2025-06-18 12:13 ` [PATCH v6 04/23] mailbox: Add common header for RPMI messages sent via mailbox Anup Patel
2025-06-18 12:13 ` [PATCH v6 05/23] mailbox: Allow controller specific mapping using fwnode Anup Patel
2025-06-23 8:45 ` Andy Shevchenko
2025-07-01 6:50 ` Anup Patel
2025-06-18 12:13 ` [PATCH v6 06/23] mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver Anup Patel
2025-06-23 8:50 ` Andy Shevchenko
2025-07-01 7:02 ` Anup Patel
2025-06-18 12:13 ` [PATCH v6 07/23] dt-bindings: clock: Add RPMI clock service message proxy bindings Anup Patel
2025-06-21 21:00 ` Stephen Boyd
2025-06-23 3:45 ` Anup Patel
2025-06-18 12:13 ` [PATCH v6 08/23] dt-bindings: clock: Add RPMI clock service controller bindings Anup Patel
2025-06-21 21:05 ` Stephen Boyd
2025-06-18 12:13 ` [PATCH v6 09/23] clk: Add clock driver for the RISC-V RPMI clock service group Anup Patel
2025-06-21 21:04 ` Stephen Boyd
2025-06-23 9:06 ` Andy Shevchenko
2025-06-26 7:02 ` Rahul Pathak
2025-06-26 14:08 ` Andy Shevchenko
2025-06-27 15:06 ` Rahul Pathak
2025-06-27 15:58 ` Andy Shevchenko
2025-06-18 12:13 ` [PATCH v6 10/23] dt-bindings: Add RPMI system MSI message proxy bindings Anup Patel
2025-06-18 12:13 ` [PATCH v6 11/23] dt-bindings: Add RPMI system MSI interrupt controller bindings Anup Patel
2025-06-18 12:13 ` [PATCH v6 12/23] irqchip: Add driver for the RPMI system MSI service group Anup Patel
2025-06-18 12:13 ` [PATCH v6 13/23] ACPI: property: Refactor acpi_fwnode_get_reference_args() Anup Patel
2025-06-23 9:08 ` Andy Shevchenko [this message]
2025-06-23 10:20 ` Rafael J. Wysocki
2025-06-18 12:13 ` [PATCH v6 14/23] ACPI: property: Add support for cells property Anup Patel
2025-06-23 9:14 ` Andy Shevchenko
2025-06-30 5:17 ` Sunil V L
2025-06-18 12:13 ` [PATCH v6 15/23] ACPI: scan: Update honor list for RPMI System MSI Anup Patel
2025-06-18 12:13 ` [PATCH v6 16/23] ACPI: RISC-V: Create interrupt controller list in sorted order Anup Patel
2025-06-18 12:13 ` [PATCH v6 17/23] ACPI: RISC-V: Add support to update gsi range Anup Patel
2025-06-18 12:13 ` [PATCH v6 18/23] ACPI: RISC-V: Add RPMI System MSI to GSI mapping Anup Patel
2025-06-18 12:13 ` [PATCH v6 19/23] irqchip/irq-riscv-imsic-early: Export imsic_acpi_get_fwnode() Anup Patel
2025-06-18 12:13 ` [PATCH v6 20/23] mailbox/riscv-sbi-mpxy: Add ACPI support Anup Patel
2025-06-18 12:13 ` [PATCH v6 21/23] irqchip/riscv-rpmi-sysmsi: " Anup Patel
2025-06-18 12:13 ` [PATCH v6 22/23] RISC-V: Enable GPIO keyboard and event device in RV64 defconfig Anup Patel
2025-06-18 12:13 ` [PATCH v6 23/23] MAINTAINERS: Add entry for RISC-V RPMI and MPXY drivers Anup Patel
2025-06-22 16:26 ` [PATCH v6 00/23] Linux SBI MPXY and RPMI drivers Jassi Brar
2025-06-23 8:51 ` Andy Shevchenko
2025-07-02 5:12 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFkZj2QCU2LfTI30@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=apatel@ventanamicro.com \
--cc=atish.patra@linux.dev \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lenb@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rpathak@ventanamicro.com \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=tglx@linutronix.de \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).