From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93D30253F12; Mon, 23 Jun 2025 14:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750687275; cv=none; b=XF5mioSW/hPml0xnvFRvVU5uYM1rf+RV5IOQpheEK62smQvKQQglqiUWUA8TBZgPsjaF8soiBjDVPDIhxGMT9XwNv8MooEeM+oBsYxTYqab7xt+8993uIAMIOxY1CJ1qixsKKXet8Ibk3bDgstByr/DGAetM+6I4jS4aC5qgIig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750687275; c=relaxed/simple; bh=8tAe+A72NPC0t11fqKX0Tq5ZNoJLrKQNS54t9kfjHag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nfw3o4qA27FxnaYCyVM6umI/YI7tkdwrWj15M2qhqKndu/oCzzGwaejvpNByum0p5rH3kOEpo3HA0dPUVj5FwpPq3THtcgPAL0dm9pyT0R6ZrMD8ogHFRxsCmPspTQp6YrzCJtBckXPfmh0PTzdOFRthpKdTmq6UtJvB2Vnvwa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sd1gUbVN; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sd1gUbVN" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UmzzfFRbv8AKrXWg42xJyMquVYU8RD5shIkkp8OhLAc=; b=sd1gUbVN/g9qIotYXNTwJKCyVk SSbd0kMv7BFDgdf81y8OdtMOMKwn1Q8FDsk1r1rQFHacQWpt/4CwJtTJ7uCEYxhMGhBIcwS6FsX5z 12kU6mYOROvl27Cd4ofQexIAodZKnxq5dP267SKr0s/s3743St9DRn3fB3SHB8a71LJ5SckyPUND7 1POQs//daeeIu1mbmz739T1Yfk16+5zjsCnZKH2DzY8ajow6ppUpCHQJWr5y+QpLNh6B/yM8eJ15l oIBuh2m6g6ttTRyetbUxahs1b6+a5W2aYzliksWa6SX30DMg1HMNwH9ZDkZmOKKZ5sRqNe0T+y2hC WuVm7hMA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uThjQ-00000002xl2-1IxF; Mon, 23 Jun 2025 14:01:08 +0000 Date: Mon, 23 Jun 2025 07:01:08 -0700 From: Christoph Hellwig To: Christian Brauner Cc: Sean Christopherson , Mike Rapoport , Vlastimil Babka , Shivank Garg , david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, viro@zeniv.linux.org.uk, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Message-ID: References: <20250619073136.506022-2-shivankg@amd.com> <20250619-fixpunkt-querfeldein-53eb22d0135f@brauner> <20250619-ablichten-korpulent-0efe2ddd0ee6@brauner> <20250623-warmwasser-giftig-ff656fce89ad@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Jun 23, 2025 at 07:00:39AM -0700, Christoph Hellwig wrote: > On Mon, Jun 23, 2025 at 12:16:27PM +0200, Christian Brauner wrote: > > I'm more than happy to switch a bunch of our exports so that we only > > allow them for specific modules. But for that we also need > > EXPOR_SYMBOL_FOR_MODULES() so we can switch our non-gpl versions. > > Huh? Any export for a specific in-tree module (or set thereof) is > by definition internals and an _GPL export if perfectly fine and > expected. .. the only thing we should do is to drop the pointless _GPL in the name entirely.